mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] bus: qcom-ebi2: make it explicitly non-modular
Date: Tue, 4 Oct 2016 00:27:01 +0200	[thread overview]
Message-ID: <CACRpkdZ-RkHzgVgAMMtAHh3ROV5eW_ftDXUURsmP_Bw37bR9jg@mail.gmail.com> (raw)
In-Reply-To: <20160927012042.6739-1-paul.gortmaker@windriver.com>

On Tue, Sep 27, 2016 at 3:20 AM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:

> The Kconfig currently controlling compilation of this code is:
>
> drivers/bus/Kconfig:config QCOM_EBI2
> drivers/bus/Kconfig:    bool "Qualcomm External Bus Interface 2 (EBI2)"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the couple traces of modular infrastructure use, so that
> when reading the driver there is no doubt it is builtin-only.
>
> Since module_platform_driver() uses the same init level priority as
> builtin_platform_driver() the init ordering remains unchanged with
> this commit.
>
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
>
> We don't replace module.h with init.h since the file already has that.
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

I was asked during review to make it a module, from originally
being a bool.

Just missed to update Kconfig as it seems :(

So the right patch is a oneliner making it tristate.

Yours,
Linus Walleij

      reply	other threads:[~2016-10-03 22:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-27  1:20 Paul Gortmaker
2016-10-03 22:27 ` Linus Walleij [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdZ-RkHzgVgAMMtAHh3ROV5eW_ftDXUURsmP_Bw37bR9jg@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®