From: Linus Walleij <linusw@kernel.org>
To: Jinjie Ruan <ruanjinjie@huawei.com>
Cc: "Paul E. McKenney" <paulmck@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Russell King <linux@armlinux.org.uk>,
Oleg Nesterov <oleg@redhat.com>,
Thomas Gleixner <tglx@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: entry: Convert IRQ handling to generic IRQ entry
Date: Thu, 6 Aug 2026 22:42:09 +0200 [thread overview]
Message-ID: <CAD++jL=ZiU4K1h7Xo8-eOGcfLEWjsHTQ9xk843T-VFoOCX7BUQ@mail.gmail.com> (raw)
In-Reply-To: <c10eb90f-3da5-48c4-9734-1913ea62bd9d@huawei.com>
Hi Jinjie,
sorry for slow return to this topic :/
On Sat, Jun 27, 2026 at 4:57 AM Jinjie Ruan <ruanjinjie@huawei.com> wrote:
> I have a small suggestion regarding the `interrupts_enabled` logic. If
> arm32 could also implement `regs_irqs_disabled(regs)` (similar to what
> arm64 and some other architectures already have), we might be able to
> unify this across subsystems.
Yes, the patch implements this, hehe :)
> Specifically, we could then replace the custom `interrupts_enabled`
> usage in both the arm64 architecture code and drivers like
> `drivers/irqchip/irq-gic-v3.c`.
That should already be possible with this patch.
I could also make a patch to replace all uses of interrupts_enabled()
with regs_irqs_disabled() as a follow-up to this patch (which introduces
regs_irqs_disabled()) if it gets accepted, I don't know if
that's a good idea though, maybe it makes the code harder
to read?
Yours,
Linus Walleij
next prev parent reply other threads:[~2026-08-06 20:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-22 22:52 Linus Walleij
2026-06-27 2:57 ` Jinjie Ruan
2026-08-06 20:42 ` Linus Walleij [this message]
2026-08-07 7:21 ` Jinjie Ruan
2026-08-07 16:02 ` Linus Walleij
2026-06-27 3:16 ` Jinjie Ruan
2026-08-06 21:22 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD++jL=ZiU4K1h7Xo8-eOGcfLEWjsHTQ9xk843T-VFoOCX7BUQ@mail.gmail.com' \
--to=linusw@kernel.org \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=oleg@redhat.com \
--cc=paulmck@kernel.org \
--cc=ruanjinjie@huawei.com \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®