Re: [PATCH] ARM: entry: Convert IRQ handling to generic IRQ entry

[Jinjie Ruan <ruanjinjie@huawei.com>]

在 2026/8/7 4:42, Linus Walleij 写道:
> Hi Jinjie,
> 
> sorry for slow return to this topic :/
> 
> On Sat, Jun 27, 2026 at 4:57 AM Jinjie Ruan <ruanjinjie@huawei.com> wrote:
> 
>> I have a small suggestion regarding the `interrupts_enabled` logic. If
>> arm32 could also implement `regs_irqs_disabled(regs)` (similar to what
>> arm64 and some other architectures already have), we might be able to
>> unify this across subsystems.
> 
> Yes, the patch implements this, hehe :)
> 
>> Specifically, we could then replace the custom `interrupts_enabled`
>> usage in both the arm64 architecture code and drivers like
>> `drivers/irqchip/irq-gic-v3.c`.
> 
> That should already be possible with this patch.
> 
> I could also make a patch to replace all uses of interrupts_enabled()
> with regs_irqs_disabled() as a follow-up to this patch (which introduces

Yes, we can replace all interrupts_enabled() including irq-gic-v3.c and
then remove the interrupts_enabled() in arch/arm64/include/asm/ptrace.h.

https://lore.kernel.org/all/ZyDu9XHNmxMHBMSI@J2N7QTR9R3.cambridge.arm.com/

> regs_irqs_disabled()) if it gets accepted, I don't know if
> that's a good idea though, maybe it makes the code harder
> to read?
> 
> Yours,
> Linus Walleij