* [RFC PATCH -next] drm/amd/display: Remove set but not unused variable 'stream_status'
@ 2020-02-10 15:08 YueHaibing
2020-02-11 16:27 ` Alex Deucher
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2020-02-10 15:08 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, alexander.deucher, christian.koenig,
David1.Zhou, airlied, daniel, Bhawanpreet.Lakha, Anthony.Koo,
aric.cyr, Dmytro.Laktyushkin, Eric.Yang2, yongqiang.sun,
martin.leung, charlene.liu
Cc: amd-gfx, dri-devel, linux-kernel, YueHaibing
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:
In function dcn10_post_unlock_program_front_end:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2623:29:
warning: variable stream_status set but not used [-Wunused-but-set-variable]
commit bbf5f6c3f83b ("drm/amd/display: Split program front end part that occur outside lock")
involved this unused variable.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
index 42fcfee..b2ed0fa 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
@@ -2610,7 +2610,7 @@ void dcn10_post_unlock_program_front_end(
struct dc *dc,
struct dc_state *context)
{
- int i, j;
+ int i;
DC_LOGGER_INIT(dc->ctx->logger);
@@ -2620,14 +2620,8 @@ void dcn10_post_unlock_program_front_end(
if (!pipe_ctx->top_pipe &&
!pipe_ctx->prev_odm_pipe &&
pipe_ctx->stream) {
- struct dc_stream_status *stream_status = NULL;
struct timing_generator *tg = pipe_ctx->stream_res.tg;
- for (j = 0; j < context->stream_count; j++) {
- if (pipe_ctx->stream == context->streams[j])
- stream_status = &context->stream_status[j];
- }
-
if (context->stream_status[i].plane_count == 0)
false_optc_underflow_wa(dc, pipe_ctx->stream, tg);
}
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RFC PATCH -next] drm/amd/display: Remove set but not unused variable 'stream_status'
2020-02-10 15:08 [RFC PATCH -next] drm/amd/display: Remove set but not unused variable 'stream_status' YueHaibing
@ 2020-02-11 16:27 ` Alex Deucher
0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2020-02-11 16:27 UTC (permalink / raw)
To: YueHaibing
Cc: Wentland, Harry, Leo (Sunpeng) Li, Deucher, Alexander,
Christian Koenig, Chunming Zhou, Dave Airlie, Daniel Vetter,
Bhawanpreet Lakha, Anthony Koo, Cyr, Aric, Dmytro Laktyushkin,
Eric Yang, Yongqiang Sun, Martin Leung, Charlene Liu,
Maling list - DRI developers, amd-gfx list, LKML
On Mon, Feb 10, 2020 at 10:38 AM YueHaibing <yuehaibing@huawei.com> wrote:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:
> In function dcn10_post_unlock_program_front_end:
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2623:29:
> warning: variable stream_status set but not used [-Wunused-but-set-variable]
>
> commit bbf5f6c3f83b ("drm/amd/display: Split program front end part that occur outside lock")
> involved this unused variable.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied. Thanks!
Alex
> ---
> drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> index 42fcfee..b2ed0fa 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> @@ -2610,7 +2610,7 @@ void dcn10_post_unlock_program_front_end(
> struct dc *dc,
> struct dc_state *context)
> {
> - int i, j;
> + int i;
>
> DC_LOGGER_INIT(dc->ctx->logger);
>
> @@ -2620,14 +2620,8 @@ void dcn10_post_unlock_program_front_end(
> if (!pipe_ctx->top_pipe &&
> !pipe_ctx->prev_odm_pipe &&
> pipe_ctx->stream) {
> - struct dc_stream_status *stream_status = NULL;
> struct timing_generator *tg = pipe_ctx->stream_res.tg;
>
> - for (j = 0; j < context->stream_count; j++) {
> - if (pipe_ctx->stream == context->streams[j])
> - stream_status = &context->stream_status[j];
> - }
> -
> if (context->stream_status[i].plane_count == 0)
> false_optc_underflow_wa(dc, pipe_ctx->stream, tg);
> }
> --
> 2.7.4
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-11 16:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-10 15:08 [RFC PATCH -next] drm/amd/display: Remove set but not unused variable 'stream_status' YueHaibing
2020-02-11 16:27 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®