mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pingfan Liu <kernelfans@gmail.com>
To: Petr Mladek <pmladek@suse.com>
Cc: sparclinux@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Andrew Morton <akpm@linux-foundation.org>,
	Wang Qing <wangqing@vivo.com>,
	Santosh Sivaraj <santosh@fossix.org>, Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH] kernel/watchdog: change prototype of watchdog_nmi_enable()
Date: Thu, 2 Sep 2021 10:53:56 +0800	[thread overview]
Message-ID: <CAFgQCTtehXTfD2rfPOzBneXPYuFsDmozDL2bUT8b1DY1K5AXeQ@mail.gmail.com> (raw)
In-Reply-To: <YSenB+Rr/4OV8EHQ@alley>

Hi Petr,

Thank you for reviewing.

But I am composing a series, which may overstep this patch. So please
drop this patch, and sorry for inconvenience.

Regards,

Pingfan

On Thu, Aug 26, 2021 at 10:36 PM Petr Mladek <pmladek@suse.com> wrote:
>
> On Tue 2021-08-24 11:14:35, Pingfan Liu wrote:
> > The only caller does not handle the return value of
> > watchdog_nmi_enable(). If there is an error, it seems to be reported by
> > arch specific code.
> >
> > Hence changing watchdog_nmi_enable() return value from int to void.
> >
> > Signed-off-by: Pingfan Liu <kernelfans@gmail.com>
>
> Looks good to me:
>
> Reviewed-by: Petr Mladek <pmladek@suse.com>
>
> Best Regards,
> Petr

      reply	other threads:[~2021-09-02  2:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-24  3:14 Pingfan Liu
2021-08-26 14:36 ` Petr Mladek
2021-09-02  2:53   ` Pingfan Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFgQCTtehXTfD2rfPOzBneXPYuFsDmozDL2bUT8b1DY1K5AXeQ@mail.gmail.com \
    --to=kernelfans@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=santosh@fossix.org \
    --cc=sparclinux@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=wangqing@vivo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®