From: Petr Mladek <pmladek@suse.com>
To: Pingfan Liu <kernelfans@gmail.com>
Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>,
Wang Qing <wangqing@vivo.com>,
Santosh Sivaraj <santosh@fossix.org>, Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH] kernel/watchdog: change prototype of watchdog_nmi_enable()
Date: Thu, 26 Aug 2021 16:36:55 +0200 [thread overview]
Message-ID: <YSenB+Rr/4OV8EHQ@alley> (raw)
In-Reply-To: <20210824031435.9664-1-kernelfans@gmail.com>
On Tue 2021-08-24 11:14:35, Pingfan Liu wrote:
> The only caller does not handle the return value of
> watchdog_nmi_enable(). If there is an error, it seems to be reported by
> arch specific code.
>
> Hence changing watchdog_nmi_enable() return value from int to void.
>
> Signed-off-by: Pingfan Liu <kernelfans@gmail.com>
Looks good to me:
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
next prev parent reply other threads:[~2021-08-26 14:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 3:14 Pingfan Liu
2021-08-26 14:36 ` Petr Mladek [this message]
2021-09-02 2:53 ` Pingfan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSenB+Rr/4OV8EHQ@alley \
--to=pmladek@suse.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=kernelfans@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=santosh@fossix.org \
--cc=sparclinux@vger.kernel.org \
--cc=tj@kernel.org \
--cc=wangqing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®