mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chen-Yu Tsai <wens@csie.org>
To: Yong Deng <yong.deng@magewell.com>
Cc: "Maxime Ripard" <maxime.ripard@free-electrons.com>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Chen-Yu Tsai" <wens@csie.org>,
	"David S. Miller" <davem@davemloft.net>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Hans Verkuil" <hans.verkuil@cisco.com>,
	"Randy Dunlap" <rdunlap@infradead.org>,
	"Benoit Parrot" <bparrot@ti.com>,
	"Stanimir Varbanov" <stanimir.varbanov@linaro.org>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Hugues Fruchet" <hugues.fruchet@st.com>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Benjamin Gaignard" <benjamin.gaignard@linaro.org>,
	"Ramesh Shanmugasundaram"
	<ramesh.shanmugasundaram@bp.renesas.com>,
	"Yannick Fertre" <yannick.fertre@st.com>,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	"Rick Chang" <rick.chang@mediatek.com>,
	"Linux Media Mailing List" <linux-media@vger.kernel.org>,
	devicetree <devicetree@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-sunxi <linux-sunxi@googlegroups.com>,
	"Ondřej Jirman" <megous@megous.com>
Subject: Re: [linux-sunxi] [PATCH v3 2/3] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)
Date: Mon, 18 Dec 2017 16:35:51 +0800	[thread overview]
Message-ID: <CAGb2v67JhMfba8Ao7WyrYikkxvTxX8WaBRqu3GkrhOCWndresg@mail.gmail.com> (raw)
In-Reply-To: <1510558344-45402-1-git-send-email-yong.deng@magewell.com>

On Mon, Nov 13, 2017 at 3:32 PM, Yong Deng <yong.deng@magewell.com> wrote:
> Add binding documentation for Allwinner V3s CSI.
>
> Signed-off-by: Yong Deng <yong.deng@magewell.com>
> ---
>  .../devicetree/bindings/media/sun6i-csi.txt        | 51 ++++++++++++++++++++++
>  1 file changed, 51 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/sun6i-csi.txt
>
> diff --git a/Documentation/devicetree/bindings/media/sun6i-csi.txt b/Documentation/devicetree/bindings/media/sun6i-csi.txt
> new file mode 100644
> index 0000000..f3916a2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/sun6i-csi.txt
> @@ -0,0 +1,51 @@
> +Allwinner V3s Camera Sensor Interface
> +------------------------------
> +
> +Required properties:
> +  - compatible: value must be "allwinner,sun8i-v3s-csi"
> +  - reg: base address and size of the memory-mapped region.
> +  - interrupts: interrupt associated to this IP
> +  - clocks: phandles to the clocks feeding the CSI
> +    * bus: the CSI interface clock
> +    * mod: the CSI module clock
> +    * ram: the CSI DRAM clock
> +  - clock-names: the clock names mentioned above
> +  - resets: phandles to the reset line driving the CSI
> +
> +- ports: A ports node with endpoint definitions as defined in
> +  Documentation/devicetree/bindings/media/video-interfaces.txt.
> +  Currently, the driver only support the parallel interface. So, a single port
> +  node with one endpoint and parallel bus is supported.
> +
> +Example:
> +
> +       csi1: csi@01cb4000 {

Drop the leading zero in the address part.

> +               compatible = "allwinner,sun8i-v3s-csi";
> +               reg = <0x01cb4000 0x1000>;
> +               interrupts = <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>;
> +               clocks = <&ccu CLK_BUS_CSI>,
> +                        <&ccu CLK_CSI1_SCLK>,

CSI also has an MCLK. Do you need that one?

ChenYu

> +                        <&ccu CLK_DRAM_CSI>;
> +               clock-names = "bus", "mod", "ram";
> +               resets = <&ccu RST_BUS_CSI>;
> +
> +               port {
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +
> +                       /* Parallel bus endpoint */
> +                       csi1_ep: endpoint {
> +                               remote-endpoint = <&adv7611_ep>;
> +                               bus-width = <16>;
> +                               data-shift = <0>;
> +
> +                               /* If hsync-active/vsync-active are missing,
> +                                  embedded BT.656 sync is used */
> +                               hsync-active = <0>; /* Active low */
> +                               vsync-active = <0>; /* Active low */
> +                               data-active = <1>;  /* Active high */
> +                               pclk-sample = <1>;  /* Rising */
> +                       };
> +               };
> +       };
> +
> --
> 1.8.3.1
>
> --
> You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

       reply	other threads:[~2017-12-18  8:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1510558344-45402-1-git-send-email-yong.deng@magewell.com>
2017-12-18  8:35 ` Chen-Yu Tsai [this message]
2017-12-18  8:49   ` Yong
2017-12-18  9:24     ` Maxime Ripard
2017-12-18  9:43       ` Yong
2017-12-18 10:46         ` Chen-Yu Tsai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGb2v67JhMfba8Ao7WyrYikkxvTxX8WaBRqu3GkrhOCWndresg@mail.gmail.com \
    --to=wens@csie.org \
    --cc=arnd@arndb.de \
    --cc=benjamin.gaignard@linaro.org \
    --cc=bparrot@ti.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hans.verkuil@cisco.com \
    --cc=hugues.fruchet@st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=mchehab@kernel.org \
    --cc=megous@megous.com \
    --cc=p.zabel@pengutronix.de \
    --cc=ramesh.shanmugasundaram@bp.renesas.com \
    --cc=rdunlap@infradead.org \
    --cc=rick.chang@mediatek.com \
    --cc=robh+dt@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=stanimir.varbanov@linaro.org \
    --cc=yannick.fertre@st.com \
    --cc=yong.deng@magewell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®