From: Barry Song <baohua@kernel.org>
To: Zhang Peng <zippermonkey@icloud.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@kernel.org>,
Lorenzo Stoakes <ljs@kernel.org>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>, Michal Hocko <mhocko@kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Shakeel Butt <shakeel.butt@linux.dev>,
Axel Rasmussen <axelrasmussen@google.com>,
Yuanchu Xie <yuanchu@google.com>, Wei Xu <weixugc@google.com>,
Qi Zheng <qi.zheng@linux.dev>,
"Liam R. Howlett" <liam@infradead.org>,
Kairui Song <kasong@tencent.com>,
Zhang Peng <bruzzhang@tencent.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/5] mm/vmscan: introduce folio_activate_locked() helper
Date: Mon, 21 Sep 2026 05:36:10 +0800 [thread overview]
Message-ID: <CAGsJ_4yGGAcS90dRLfpUNWGdPhR-foAXM19b84nCtvkvcRstSA@mail.gmail.com> (raw)
In-Reply-To: <20260920143816.39827-1-zippermonkey@icloud.com>
On Sun, Sep 20, 2026 at 10:38 PM Zhang Peng <zippermonkey@icloud.com> wrote:
[...]
>
> I've split the series accordingly. The four cleanup patches, with the
> explicit-outcome rework you asked for in 2/5 and 3/5, are posted on
> their own as:
>
> [PATCH 0/4] mm/vmscan: refactor shrink_folio_list()
> https://lore.kernel.org/all/20260920-vmscan-refactor-v1-0-ec04d71cb761@tencent.com/
>
> No functional change intended there. I'll repost the TLB batching on
> top once that has settled.
Hi Zhang Peng,
I am happy to review your `shrink_folio_list()` refactoring series, but
I really don't think it should be split up, as the refactoring is
closely tied to your final patch, "batch dirty TLBI".
Without the last patch, the refactoring doesn't really stand on its own.
So I'd prefer you to keep all five patches together as a single patchset.
Best Regards
Barry
next prev parent reply other threads:[~2026-09-20 21:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 5:07 [PATCH v5 0/5] mm: batch TLB flushing for dirty folios in vmscan Zhang Peng
2026-07-20 5:07 ` [PATCH v5 1/5] mm/vmscan: introduce folio_activate_locked() helper Zhang Peng
2026-08-10 8:36 ` Barry Song
2026-09-20 14:38 ` Zhang Peng
2026-09-20 21:36 ` Barry Song [this message]
2026-09-20 21:49 ` Barry Song
2026-07-20 5:07 ` [PATCH v5 2/5] mm/vmscan: extract folio_free() from shrink_folio_list() Zhang Peng
2026-08-13 21:40 ` Barry Song
2026-09-20 14:45 ` Zhang Peng
2026-07-20 5:07 ` [PATCH v5 3/5] mm/vmscan: extract pageout_one() " Zhang Peng
2026-08-13 21:49 ` Barry Song
2026-09-20 14:46 ` Zhang Peng
2026-07-20 5:07 ` [PATCH v5 4/5] mm/vmscan: extract folio unmap logic into folio_try_unmap() Zhang Peng
2026-08-13 21:52 ` Barry Song
2026-07-20 5:07 ` [PATCH v5 5/5] mm/vmscan: flush TLB for every 31 folios evictions Zhang Peng
2026-08-13 21:58 ` Barry Song
2026-09-20 14:47 ` Zhang Peng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGsJ_4yGGAcS90dRLfpUNWGdPhR-foAXM19b84nCtvkvcRstSA@mail.gmail.com \
--to=baohua@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=bruzzhang@tencent.com \
--cc=david@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kasong@tencent.com \
--cc=liam@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=qi.zheng@linux.dev \
--cc=rppt@kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=weixugc@google.com \
--cc=yuanchu@google.com \
--cc=zippermonkey@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®