From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Kostenzer Felix <fkostenzer@live.at>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] lib: sort: make it explicitly non-modular
Date: Wed, 18 Jan 2017 20:03:57 +0200 [thread overview]
Message-ID: <CAHp75VczShaS0Gdm_hbWcgW-Vp12Z2XLSSU=bY1DWCKmMirczw@mail.gmail.com> (raw)
In-Reply-To: <20170118162009.24763-1-paul.gortmaker@windriver.com>
On Wed, Jan 18, 2017 at 6:20 PM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
> The Makefile currently controlling compilation of this code is:
>
> lib/Kconfig.debug:config TEST_SORT
> lib/Kconfig.debug: bool "Array-based sort test"
>
> and...
>
> lib/Makefile:obj-y += bcd.o div64.o sort.o [...]
>
> ...meaning that it currently is not being built as a module by anyone.
Perhaps allow it to be a module?
Besides that perhaps rename to something like test_sort.c ?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2017-01-18 18:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 16:20 Paul Gortmaker
2017-01-18 18:03 ` Andy Shevchenko [this message]
2017-01-18 19:31 ` Paul Gortmaker
2017-01-18 20:31 ` Felix Kostenzer
2017-01-19 0:41 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VczShaS0Gdm_hbWcgW-Vp12Z2XLSSU=bY1DWCKmMirczw@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=fkostenzer@live.at \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®