From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Jean Delvare <jdelvare@suse.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH] firmware: dmi: Check DMI structure length
Date: Thu, 1 Jun 2017 16:16:05 +0300 [thread overview]
Message-ID: <CAHp75Vf7R_GeFhA5c2PR42K=cp-UbK4u2o7B5N9Ceu_NdFXmzg@mail.gmail.com> (raw)
In-Reply-To: <20170601150839.08fdb556@endymion>
On Thu, Jun 1, 2017 at 4:08 PM, Jean Delvare <jdelvare@suse.de> wrote:
> Before accessing DMI data to record it for later, we should ensure
> that the DMI structures are large enough to contain the data in
> question.
> - const u8 *d = (u8 *) dm + index;
> + const u8 *d;
> + d = (u8 *) dm + index;
I think you may leave this as is and make it compiler's burden to optimize.
> - const u8 *d = (u8 *) dm + index;
> + const u8 *d;
> + d = (u8 *) dm + index;
Ditto.
> - int i, count = *(u8 *)(dm + 1);
> + int i, count;
> + count = *(u8 *)(dm + 1);
Ditto.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2017-06-01 13:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-01 13:08 Jean Delvare
2017-06-01 13:16 ` Andy Shevchenko [this message]
2017-06-01 14:40 ` Jean Delvare
2017-06-01 16:06 ` Andy Shevchenko
2017-06-02 18:40 ` Jean Delvare
2017-06-02 18:45 ` Andy Shevchenko
2017-06-03 21:14 ` Jean Delvare
2017-06-01 14:00 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vf7R_GeFhA5c2PR42K=cp-UbK4u2o7B5N9Ceu_NdFXmzg@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jdelvare@suse.de \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®