Re: [linux-sunxi] Re: [PATCH] arm64: dts: allwinner: a64: Disable SPDIF by default

["Clément Péron" <peron.clem@gmail.com>]

Hi Samuel, Maxime,

On Thu, 23 Apr 2020 at 01:50, Samuel Holland <samuel@sholland.org> wrote:
>
> Maxime,
>
> On 4/22/20 10:16 AM, Maxime Ripard wrote:
> > On Tue, Apr 21, 2020 at 11:15:02PM -0500, Samuel Holland wrote:
> >> As of v5.7-rc2, Linux now prints the following message at boot:
> >>
> >>   [   33.848525] platform sound_spdif: deferred probe pending
> >>
> >> This is because &sound_spdif is waiting on its DAI link component
> >> &spdif to probe, but &spdif is disabled in the DTS. Disable the
> >> audio card as well to match.
> >>
> >> Signed-off-by: Samuel Holland <samuel@sholland.org>
> >
> > The patch looks good, but don't we have some boards with SPDIF enabled that
> > should be modified accordingly?
>
> I don't see any in-tree. The only A64 DTS that references &spdif at all is
> sun50i-a64-pine64.dts, which explicitly disables it:

This has been introduced by Marcus Cooper for the Pine64 audio extension.
https://store.pine64.org/?product=pine64-stereo-audio-dac-pot-board

So this should be moved to an overlay no?

Regards,
Clement

>
>         /* On Euler connector */
>         &spdif {
>                 status = "disabled";
>         };
>
> I'm leaning toward agreeing with Clement that the sound_spdif node (and also
> spdif_out) should be removed altogether from the A64 DTSI.
>
> Regards,
> Samuel
>
> --
> You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com.
> To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/b554ea70-16da-1637-d349-db51dddcf95b%40sholland.org.