From: Samuel Holland <samuel@sholland.org>
To: Maxime Ripard <maxime@cerno.tech>
Cc: Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH] arm64: dts: allwinner: a64: Disable SPDIF by default
Date: Wed, 22 Apr 2020 18:50:54 -0500 [thread overview]
Message-ID: <b554ea70-16da-1637-d349-db51dddcf95b@sholland.org> (raw)
In-Reply-To: <20200422151616.httmhmo2tbd4m4eu@gilmour.lan>
Maxime,
On 4/22/20 10:16 AM, Maxime Ripard wrote:
> On Tue, Apr 21, 2020 at 11:15:02PM -0500, Samuel Holland wrote:
>> As of v5.7-rc2, Linux now prints the following message at boot:
>>
>> [ 33.848525] platform sound_spdif: deferred probe pending
>>
>> This is because &sound_spdif is waiting on its DAI link component
>> &spdif to probe, but &spdif is disabled in the DTS. Disable the
>> audio card as well to match.
>>
>> Signed-off-by: Samuel Holland <samuel@sholland.org>
>
> The patch looks good, but don't we have some boards with SPDIF enabled that
> should be modified accordingly?
I don't see any in-tree. The only A64 DTS that references &spdif at all is
sun50i-a64-pine64.dts, which explicitly disables it:
/* On Euler connector */
&spdif {
status = "disabled";
};
I'm leaning toward agreeing with Clement that the sound_spdif node (and also
spdif_out) should be removed altogether from the A64 DTSI.
Regards,
Samuel
next prev parent reply other threads:[~2020-04-22 23:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 4:15 Samuel Holland
2020-04-22 9:14 ` [linux-sunxi] " Clément Péron
2020-04-22 15:16 ` Maxime Ripard
2020-04-22 23:50 ` Samuel Holland [this message]
2020-04-23 7:35 ` [linux-sunxi] " Clément Péron
2020-04-23 9:49 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b554ea70-16da-1637-d349-db51dddcf95b@sholland.org \
--to=samuel@sholland.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime@cerno.tech \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®