From: Masahiro Yamada <masahiroy@kernel.org>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
Linux-sh list <linux-sh@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
David Hildenbrand <david@redhat.com>,
Michal Hocko <mhocko@suse.com>,
Mike Rapoport <rppt@linux.ibm.com>,
Oscar Salvador <osalvador@suse.de>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] sh: fix build error in mm/init.c
Date: Tue, 14 Apr 2020 01:04:23 +0900 [thread overview]
Message-ID: <CAK7LNAQmbFOtsBAO2y_s9_y90UGCjXWrd-Es9mOUjgrfCELqmA@mail.gmail.com> (raw)
In-Reply-To: <ef8addd0-81bb-249f-7d8f-dfa7fc032085@deltatee.com>
On Tue, Apr 14, 2020 at 12:43 AM Logan Gunthorpe <logang@deltatee.com> wrote:
>
>
>
> On 2020-04-12 7:47 p.m., Masahiro Yamada wrote:
> > The closing parenthesis is missing.
> >
> > Fixes: bfeb022f8fe4 ("mm/memory_hotplug: add pgprot_t to mhp_params")
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> > ---
>
> Oh, oops, I thought I compile checked all the arches. Must have been a
> last minute change. I'm also surprised the kbuild robot didn't catch this.
>
> Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
>
> Andrew, can this be squashed into the existing patch?
The offending commit is already in Linus' tree.
I was also surprised that no bot or human
complained about this breakage before it was merged.
--
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2020-04-13 16:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 1:47 Masahiro Yamada
2020-04-13 7:42 ` Geert Uytterhoeven
2020-04-13 15:43 ` Logan Gunthorpe
2020-04-13 16:04 ` Masahiro Yamada [this message]
2020-04-19 20:46 ` Masahiro Yamada
2020-04-19 20:49 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNAQmbFOtsBAO2y_s9_y90UGCjXWrd-Es9mOUjgrfCELqmA@mail.gmail.com \
--to=masahiroy@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dalias@libc.org \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=rppt@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®