mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] scripts/gdb: fix symbol link when run make cmd out of tree
@ 2024-05-22  4:07 Wu Bo
  2024-05-22 10:38 ` Masahiro Yamada
  0 siblings, 1 reply; 2+ messages in thread
From: Wu Bo @ 2024-05-22  4:07 UTC (permalink / raw)
  To: linux-kernel
  Cc: Jan Kiszka, Kieran Bingham, Nicolas Schier, Wu Bo,
	Masahiro Yamada, Wu Bo

When running 'make scripts_gdb' command out of kernel source tree, the
symbol links gennerated under build-dir/scripts/gdb/linux is invalid.

$(srctree)/$(src) need to be replaced with $(src) since
commit b1992c3772e6 ("kbuild: use $(src) instead of $(srctree)/$(src)
for source directory")

Signed-off-by: Wu Bo <bo.wu@vivo.com>
---
 scripts/gdb/linux/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/gdb/linux/Makefile b/scripts/gdb/linux/Makefile
index d77ad9079d0f..fcd32fcf3ae0 100644
--- a/scripts/gdb/linux/Makefile
+++ b/scripts/gdb/linux/Makefile
@@ -5,7 +5,7 @@ ifdef building_out_of_srctree
 symlinks := $(patsubst $(src)/%,%,$(wildcard $(src)/*.py))
 
 quiet_cmd_symlink = SYMLINK $@
-      cmd_symlink = ln -fsn $(patsubst $(obj)/%,$(abspath $(srctree))/$(src)/%,$@) $@
+      cmd_symlink = ln -fsn $(patsubst $(obj)/%,$(abspath $(src))/%,$@) $@
 
 always-y += $(symlinks)
 $(addprefix $(obj)/, $(symlinks)): FORCE
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] scripts/gdb: fix symbol link when run make cmd out of tree
  2024-05-22  4:07 [PATCH] scripts/gdb: fix symbol link when run make cmd out of tree Wu Bo
@ 2024-05-22 10:38 ` Masahiro Yamada
  0 siblings, 0 replies; 2+ messages in thread
From: Masahiro Yamada @ 2024-05-22 10:38 UTC (permalink / raw)
  To: Wu Bo; +Cc: linux-kernel, Jan Kiszka, Kieran Bingham, Nicolas Schier, Wu Bo

On Wed, May 22, 2024 at 12:55 PM Wu Bo <bo.wu@vivo.com> wrote:
>
> When running 'make scripts_gdb' command out of kernel source tree, the
> symbol links gennerated under build-dir/scripts/gdb/linux is invalid.
>
> $(srctree)/$(src) need to be replaced with $(src) since
> commit b1992c3772e6 ("kbuild: use $(src) instead of $(srctree)/$(src)
> for source directory")
>
> Signed-off-by: Wu Bo <bo.wu@vivo.com>
> ---


This was fixed in today's linux-next.

commit ab32efe0e2b6ab01ba079995071da8d587c976cc
Author: Douglas Anderson <dianders@chromium.org>
Date:   Mon May 20 12:56:52 2024 -0700

    kbuild: scripts/gdb: Replace missed $(srctree)/$(src) w/ $(src)





--
Best Regards
Masahiro Yamada

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-05-22 10:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-22  4:07 [PATCH] scripts/gdb: fix symbol link when run make cmd out of tree Wu Bo
2024-05-22 10:38 ` Masahiro Yamada

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®