From: Namjae Jeon <linkinjeon@kernel.org>
To: Ian Bridges <icb@fastmail.org>
Cc: mike.michalo@gmail.com, senozhatsky@chromium.org, tom@talpey.com,
linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ksmbd: sign the last response of a compound that ends early
Date: Fri, 13 Nov 2026 07:33:34 +0900 [thread overview]
Message-ID: <CAKYAXd9DFfHMje35Ttag9dQiDsQmCd6QrAwC6SHF57PeE_ysFA@mail.gmail.com> (raw)
In-Reply-To: <20261112205551.1668102-1-icb@fastmail.org>
On Fri, Nov 13, 2026 at 5:56 AM Ian Bridges <icb@fastmail.org> wrote:
>
> I tested this with the ksmbd code from ksmbd-for-next. I sent a signed
> compound of two ECHOs whose second NextCommand covers only that
> command, so the compound ends early. Before the patch, the first
> response carried a signature that did not verify and the second was
> not signed. With the patch, both responses are signed and verify. A
> normal signed compound gives the same result as before, and the
> connection keeps working in both cases. smbtorture gives the same
> results as without the patch, and KASAN reports nothing.
>
> Reviewed-by: Ian Bridges <icb@fastmail.org>
> Tested-by: Ian Bridges <icb@fastmail.org>
Applied it to #ksmbd-for-next.
Thanks!
prev parent reply other threads:[~2026-11-12 22:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 19:47 Michail Andreas Michalopoulos
2026-11-12 20:55 ` Ian Bridges
2026-11-12 22:33 ` Namjae Jeon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKYAXd9DFfHMje35Ttag9dQiDsQmCd6QrAwC6SHF57PeE_ysFA@mail.gmail.com \
--to=linkinjeon@kernel.org \
--cc=icb@fastmail.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.michalo@gmail.com \
--cc=senozhatsky@chromium.org \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®