From: Jim Mattson <jmattson@google.com>
To: "Chang S. Bae" <chang.seok.bae@intel.com>
Cc: seanjc@google.com, pbonzini@redhat.com, kvm@vger.kernel.org,
x86@kernel.org, linux-kernel@vger.kernel.org,
zhao1.liu@intel.com
Subject: Re: [PATCH v9 03/20] KVM: x86: Support EGPRs on VCPU RESET/INIT events
Date: Tue, 17 Nov 2026 20:44:16 -0800 [thread overview]
Message-ID: <CALMp9eRtQ4FLf5YTwwwpLAamH866KBmbVpGa81A-A-R2vdq4kA@mail.gmail.com> (raw)
In-Reply-To: <20261117180310.921701-4-chang.seok.bae@intel.com>
On Tue, Nov 17, 2026 at 10:31 AM Chang S. Bae <chang.seok.bae@intel.com> wrote:
>
> EGPRs are not zeroed on CPU INIT. Handle each register based on index to
> support this EGPR behavior while preserving the existing behavior for
> legacy GPRs.
>
> Refactor the rest of GPR handling together as the reset comment mentions it.
>
> Signed-off-by: Chang S. Bae <chang.seok.bae@intel.com>
> ---
> V8 -> V9: New patch (Jim Mattson)
> ---
> arch/x86/kvm/x86.c | 40 ++++++++++++++++++++++++++--------------
> 1 file changed, 26 insertions(+), 14 deletions(-)
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 2cd9ee316aad..73bb1d25931c 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -9601,9 +9601,33 @@ static void kvm_xstate_reset(struct kvm_vcpu *vcpu, bool init_event)
> kvm_load_guest_fpu(vcpu);
> }
>
> -void kvm_vcpu_reset(struct kvm_vcpu *vcpu, bool init_event)
> +static void kvm_vcpu_regs_reset(struct kvm_vcpu *vcpu, bool init_event)
> {
> struct kvm_cpuid_entry2 *cpuid_0x1;
> + int idx;
> +
> + /*
> + * All legacy GPRs except RDX (handled below) are zeroed on RESET/INIT.
> + * EGPRs (R16-R31), however, retain their values on INIT.
> + */
> + for (idx = VCPU_REGS_RAX; idx < NR_VCPU_GENERAL_PURPOSE_REGS; idx++)
> + vcpu->arch.regs[idx] = idx > 15 && init_event ? vcpu->arch.regs[idx] : 0;
Nit: I'd rather not see a bare 15 here, though I realize that
VCPU_REGS_R16 doesn't exist when CONFIG_KVM_APX=n. Perhaps define the
number of legacy GPRs in kvm_host.h:
#ifdef CONFIG_X86_64
#define NR_VCPU_LEGACY_GPRS (VCPU_REGS_R15 + 1)
#else
#define NR_VCPU_LEGACY_GPRS (VCPU_REGS_RDI + 1)
#endif
and then this becomes:
/*
* All legacy GPRs except RDX (handled below) are zeroed on
* RESET/INIT. EGPRs (R16-R31) are zeroed on RESET, but are
* unchanged on INIT.
*/
memset(vcpu->arch.regs, 0,
init_event ? NR_VCPU_LEGACY_GPRS * sizeof(vcpu->arch.regs[0]) :
sizeof(vcpu->arch.regs));
With that change,
Reviewed-by: Jim Mattson <jmattson@google.com>
next prev parent reply other threads:[~2026-11-18 4:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 18:02 [PATCH v9 00/20] KVM: x86: Enable APX for guest Chang S. Bae
2026-11-17 18:02 ` [PATCH v9 01/20] KVM: x86: Extend VCPU registers for EGPRs Chang S. Bae
2026-11-18 4:12 ` Jim Mattson
2026-11-17 18:02 ` [PATCH v9 02/20] KVM: VMX: Save guest EGPRs in VCPU cache Chang S. Bae
2026-11-17 18:02 ` [PATCH v9 03/20] KVM: x86: Support EGPRs on VCPU RESET/INIT events Chang S. Bae
2026-11-18 4:44 ` Jim Mattson [this message]
2026-11-17 18:02 ` [PATCH v9 04/20] KVM: x86: Support APX state for XSAVE ABI Chang S. Bae
2026-11-17 18:02 ` [PATCH v9 05/20] KVM: VMX: Refactor VMX instruction information access Chang S. Bae
2026-11-17 18:02 ` [PATCH v9 06/20] KVM: VMX: Refactor instruction information decoding Chang S. Bae
2026-11-17 18:02 ` [PATCH v9 07/20] KVM: VMX: Remove unused control-register access defines Chang S. Bae
2026-11-17 18:02 ` [PATCH v9 08/20] KVM: VMX: Refactor register index retrieval from exit qualification Chang S. Bae
2026-11-17 18:02 ` [PATCH v9 09/20] KVM: VMX: Support instruction information extension Chang S. Bae
2026-11-18 4:13 ` Jim Mattson
2026-11-17 18:03 ` [PATCH v9 10/20] KVM: nVMX: Propagate extended instruction information Chang S. Bae
2026-11-18 4:14 ` Jim Mattson
2026-11-17 18:03 ` [PATCH v9 11/20] KVM: x86: Support EGPR accessing and tracking for emulator Chang S. Bae
2026-11-17 18:03 ` [PATCH v9 12/20] KVM: x86: Handle EGPR index and REX2-incompatible opcodes Chang S. Bae
2026-11-17 18:03 ` [PATCH v9 13/20] KVM: x86: Support REX2-prefixed opcode decode Chang S. Bae
2026-11-17 18:03 ` [PATCH v9 14/20] KVM: x86: Document EVEX-prefix not implemented Chang S. Bae
2026-11-17 18:03 ` [PATCH v9 15/20] KVM: x86: Move KVM_SUPPORTED_{XCR0,XSS} into kvm_x86_vendor_init() Chang S. Bae
2026-11-17 18:03 ` [PATCH v9 16/20] KVM: x86: Guard valid XCR0.APX settings Chang S. Bae
2026-11-17 18:03 ` [PATCH v9 17/20] KVM: x86: Add APX to supported XCR0 Chang S. Bae
2026-11-17 18:03 ` [PATCH v9 18/20] KVM: x86: Expose APX feature to userspace Chang S. Bae
2026-11-17 18:03 ` [PATCH v9 19/20] KVM: selftests: Add APX state and ABI test Chang S. Bae
2026-11-17 18:03 ` [PATCH v9 20/20] KVM: selftests: Add APX state handling and XCR0 sanity checks Chang S. Bae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALMp9eRtQ4FLf5YTwwwpLAamH866KBmbVpGa81A-A-R2vdq4kA@mail.gmail.com \
--to=jmattson@google.com \
--cc=chang.seok.bae@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=x86@kernel.org \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®