mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0/2] Make AUDIO_CLKOUT optional and drop it from RZ/G3E SMARC
@ 2026-08-20  9:57 Tommaso Merciai
  2026-08-20  9:57 ` [PATCH 1/2] dt-bindings: sound: renesas,r9a09g047-sound: Drop #clock-cells from required Tommaso Merciai
  2026-08-20  9:57 ` [PATCH 2/2] arm64: dts: renesas: r9a09g047e57-smarc: Drop AUDIO_CLKOUT properties Tommaso Merciai
  0 siblings, 2 replies; 5+ messages in thread
From: Tommaso Merciai @ 2026-08-20  9:57 UTC (permalink / raw)
  To: tomm.merciai
  Cc: linux-renesas-soc, biju.das.jz, Tommaso Merciai, Liam Girdwood,
	Mark Brown, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Geert Uytterhoeven, Magnus Damm, Kuninori Morimoto, John Madieu,
	linux-sound, devicetree, linux-kernel

Dear All,

This series makes #clock-cells optional in the renesas,r9a09g047-sound
binding, since the node acts as a clock provider only on boards that
route AUDIO_CLKOUT, and drops the corresponding AUDIO_CLKOUT properties
from r9a09g047e57-smarc.dts, where the pin is neither pinmuxed nor
consumed. The DA7212 MCLK comes from the on-board versa3.

This fix also addresses the following warning:

sound@13c00000 (renesas,r9a09g047-sound): Unevaluated properties are not
allowed ('clock-frequency' was unexpected)

Spotted running dtbs_check with -W=1.

Kind regards,
Tommaso

Tommaso Merciai (2):
  dt-bindings: sound: renesas,r9a09g047-sound: Drop #clock-cells from
    required
  arm64: dts: renesas: r9a09g047e57-smarc: Drop AUDIO_CLKOUT properties

 .../devicetree/bindings/sound/renesas,r9a09g047-sound.yaml    | 1 -
 arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts            | 4 ----
 2 files changed, 5 deletions(-)

-- 
2.54.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/2] dt-bindings: sound: renesas,r9a09g047-sound: Drop #clock-cells from required
  2026-08-20  9:57 [PATCH 0/2] Make AUDIO_CLKOUT optional and drop it from RZ/G3E SMARC Tommaso Merciai
@ 2026-08-20  9:57 ` Tommaso Merciai
  2026-08-20 10:13   ` Geert Uytterhoeven
  2026-08-20  9:57 ` [PATCH 2/2] arm64: dts: renesas: r9a09g047e57-smarc: Drop AUDIO_CLKOUT properties Tommaso Merciai
  1 sibling, 1 reply; 5+ messages in thread
From: Tommaso Merciai @ 2026-08-20  9:57 UTC (permalink / raw)
  To: tomm.merciai
  Cc: linux-renesas-soc, biju.das.jz, Tommaso Merciai, Liam Girdwood,
	Mark Brown, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Geert Uytterhoeven, Magnus Damm, Kuninori Morimoto, John Madieu,
	linux-sound, devicetree, linux-kernel

`#clock-cells` declares the node as a clock provider for AUDIO_CLKOUT,
which only makes sense on boards that route that pin.

Drop it from the required list so that boards which do not wire
AUDIO_CLKOUT can leave it out.

Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
---
 .../devicetree/bindings/sound/renesas,r9a09g047-sound.yaml       | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.yaml b/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.yaml
index 213c1c40b6f0..8b65a5713250 100644
--- a/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.yaml
+++ b/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.yaml
@@ -298,7 +298,6 @@ required:
   - reg
   - reg-names
   - "#sound-dai-cells"
-  - "#clock-cells"
   - clocks
   - clock-names
   - resets
-- 
2.54.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 2/2] arm64: dts: renesas: r9a09g047e57-smarc: Drop AUDIO_CLKOUT properties
  2026-08-20  9:57 [PATCH 0/2] Make AUDIO_CLKOUT optional and drop it from RZ/G3E SMARC Tommaso Merciai
  2026-08-20  9:57 ` [PATCH 1/2] dt-bindings: sound: renesas,r9a09g047-sound: Drop #clock-cells from required Tommaso Merciai
@ 2026-08-20  9:57 ` Tommaso Merciai
  1 sibling, 0 replies; 5+ messages in thread
From: Tommaso Merciai @ 2026-08-20  9:57 UTC (permalink / raw)
  To: tomm.merciai
  Cc: linux-renesas-soc, biju.das.jz, Tommaso Merciai, Liam Girdwood,
	Mark Brown, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Geert Uytterhoeven, Magnus Damm, Kuninori Morimoto, John Madieu,
	linux-sound, devicetree, linux-kernel

AUDIO_CLKOUT is neither pinmuxed nor consumed on this board, so the node is
not a clock provider: #clock-cells and clock-frequency describe an output
that does not exist here. The DA7212 MCLK comes from the on-board versa3.

Fixes: 3e23d2548ddb ("arm64: dts: renesas: r9a09g047e57-smarc: Add DA7212 audio codec support")
Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
---
 arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts b/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
index 4eed095b683b..d43b50bca4a8 100644
--- a/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
+++ b/arch/arm64/boot/dts/renesas/r9a09g047e57-smarc.dts
@@ -362,10 +362,6 @@ &snd_rzg3e {
 
 	status = "okay";
 
-	/* audio_clkout */
-	#clock-cells = <0>;
-	clock-frequency = <11289600>;
-
 	/* Multi DAI */
 	#sound-dai-cells = <1>;
 
-- 
2.54.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] dt-bindings: sound: renesas,r9a09g047-sound: Drop #clock-cells from required
  2026-08-20  9:57 ` [PATCH 1/2] dt-bindings: sound: renesas,r9a09g047-sound: Drop #clock-cells from required Tommaso Merciai
@ 2026-08-20 10:13   ` Geert Uytterhoeven
  2026-08-20 15:05     ` Tommaso Merciai
  0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2026-08-20 10:13 UTC (permalink / raw)
  To: Tommaso Merciai
  Cc: tomm.merciai, linux-renesas-soc, biju.das.jz, Liam Girdwood,
	Mark Brown, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Magnus Damm, Kuninori Morimoto, John Madieu, linux-sound,
	devicetree, linux-kernel

Hi Tommaso,

On Thu, 20 Aug 2026 at 11:58, Tommaso Merciai
<tommaso.merciai.xr@bp.renesas.com> wrote:
> `#clock-cells` declares the node as a clock provider for AUDIO_CLKOUT,
> which only makes sense on boards that route that pin.
>
> Drop it from the required list so that boards which do not wire
> AUDIO_CLKOUT can leave it out.
>
> Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>

Thanks for your patch!

> --- a/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.yaml
> +++ b/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.yaml
> @@ -298,7 +298,6 @@ required:
>    - reg
>    - reg-names
>    - "#sound-dai-cells"
> -  - "#clock-cells"
>    - clocks
>    - clock-names
>    - resets

I disagree: this is a property of the sound block, not of board wiring.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [PATCH 1/2] dt-bindings: sound: renesas,r9a09g047-sound: Drop #clock-cells from required
  2026-08-20 10:13   ` Geert Uytterhoeven
@ 2026-08-20 15:05     ` Tommaso Merciai
  0 siblings, 0 replies; 5+ messages in thread
From: Tommaso Merciai @ 2026-08-20 15:05 UTC (permalink / raw)
  To: geert
  Cc: Tommaso Merciai, linux-renesas-soc, Biju Das, Liam Girdwood,
	Mark Brown, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	magnus.damm, Kuninori Morimoto, John Madieu, linux-sound,
	devicetree, linux-kernel

Hi Geert,
Thanks for your review!

> -----Original Message-----
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: Thursday, August 20, 2026 12:14 PM
> To: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
> Cc: Tommaso Merciai <tomm.merciai@gmail.com>; linux-renesas-
> soc@vger.kernel.org; Biju Das <biju.das.jz@bp.renesas.com>; Liam Girdwood
> <lgirdwood@gmail.com>; Mark Brown <broonie@kernel.org>; Rob Herring
> <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley
> <conor+dt@kernel.org>; magnus.damm <magnus.damm@gmail.com>; Kuninori
> Morimoto <kuninori.morimoto.gx@renesas.com>; John Madieu
> <john.madieu.xa@bp.renesas.com>; linux-sound@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 1/2] dt-bindings: sound: renesas,r9a09g047-sound: Drop
> #clock-cells from required
> 
> Hi Tommaso,
> 
> On Thu, 20 Aug 2026 at 11:58, Tommaso Merciai
> <tommaso.merciai.xr@bp.renesas.com> wrote:
> > `#clock-cells` declares the node as a clock provider for AUDIO_CLKOUT,
> > which only makes sense on boards that route that pin.
> >
> > Drop it from the required list so that boards which do not wire
> > AUDIO_CLKOUT can leave it out.
> >
> > Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
> 
> Thanks for your patch!
> 
> > ---
> > a/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.yaml
> > +++ b/Documentation/devicetree/bindings/sound/renesas,r9a09g047-sound.
> > +++ yaml
> > @@ -298,7 +298,6 @@ required:
> >    - reg
> >    - reg-names
> >    - "#sound-dai-cells"
> > -  - "#clock-cells"
> >    - clocks
> >    - clock-names
> >    - resets
> 
> I disagree: this is a property of the sound block, not of board wiring.

Maybe better to drop this patch.
Move #clock-cells = <0>; from r9a09g047e57-smarc.dts to r9a09g047.dtsi
Drop clock-frequency = <11289600>; from r9a09g047e57-smarc.dts

What do you think?

Kind regards,
Tommaso

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
>                                 -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-08-20 15:05 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-20  9:57 [PATCH 0/2] Make AUDIO_CLKOUT optional and drop it from RZ/G3E SMARC Tommaso Merciai
2026-08-20  9:57 ` [PATCH 1/2] dt-bindings: sound: renesas,r9a09g047-sound: Drop #clock-cells from required Tommaso Merciai
2026-08-20 10:13   ` Geert Uytterhoeven
2026-08-20 15:05     ` Tommaso Merciai
2026-08-20  9:57 ` [PATCH 2/2] arm64: dts: renesas: r9a09g047e57-smarc: Drop AUDIO_CLKOUT properties Tommaso Merciai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®