From: Eric Dumazet <edumazet@google.com>
To: Andrzej Hajda <andrzej.hajda@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org,
Chris Wilson <chris@chris-wilson.co.uk>,
netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
Dmitry Vyukov <dvyukov@google.com>,
"David S. Miller" <davem@davemloft.net>,
Andi Shyti <andi.shyti@linux.intel.com>
Subject: Re: [PATCH v7 1/7] lib/ref_tracker: add unlocked leak print helper
Date: Fri, 21 Apr 2023 16:24:43 +0200 [thread overview]
Message-ID: <CANn89iL65YYs_+cJs6STTH=7n22VLi-eru2FzFh1rtrxp_a7Aw@mail.gmail.com> (raw)
In-Reply-To: <20230224-track_gt-v7-1-11f08358c1ec@intel.com>
On Fri, Apr 21, 2023 at 1:35 PM Andrzej Hajda <andrzej.hajda@intel.com> wrote:
>
> To have reliable detection of leaks, caller must be able to check under the same
> lock both: tracked counter and the leaks. dir.lock is natural candidate for such
> lock and unlocked print helper can be called with this lock taken.
> As a bonus we can reuse this helper in ref_tracker_dir_exit.
>
> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
> ---
SGTM, thanks.
Reviewed-by: Eric Dumazet <edumazet@google.com>
next prev parent reply other threads:[~2023-04-21 14:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 11:35 [PATCH v7 0/7] drm/i915: use ref_tracker library for tracking wakerefs Andrzej Hajda
2023-04-21 11:35 ` [PATCH v7 1/7] lib/ref_tracker: add unlocked leak print helper Andrzej Hajda
2023-04-21 14:24 ` Eric Dumazet [this message]
2023-04-21 11:35 ` [PATCH v7 2/7] lib/ref_tracker: improve printing stats Andrzej Hajda
2023-04-21 14:21 ` Eric Dumazet
2023-04-21 14:30 ` Andrzej Hajda
2023-04-21 11:35 ` [PATCH v7 3/7] lib/ref_tracker: add printing to memory buffer Andrzej Hajda
2023-04-21 11:35 ` [PATCH v7 4/7] lib/ref_tracker: remove warnings in case of allocation failure Andrzej Hajda
2023-04-21 14:21 ` Eric Dumazet
2023-04-21 11:35 ` [PATCH v7 5/7] drm/i915: Correct type of wakeref variable Andrzej Hajda
2023-04-21 11:35 ` [PATCH v7 6/7] drm/i915: Replace custom intel runtime_pm tracker with ref_tracker library Andrzej Hajda
2023-04-23 4:45 ` Zhou Furong
2023-04-21 11:35 ` [PATCH v7 7/7] drm/i915: track gt pm wakerefs Andrzej Hajda
2023-04-23 3:53 ` Zhou Furong
2023-04-21 14:09 ` [PATCH v7 0/7] drm/i915: use ref_tracker library for tracking wakerefs Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANn89iL65YYs_+cJs6STTH=7n22VLi-eru2FzFh1rtrxp_a7Aw@mail.gmail.com' \
--to=edumazet@google.com \
--cc=airlied@gmail.com \
--cc=andi.shyti@linux.intel.com \
--cc=andrzej.hajda@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=dvyukov@google.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®