* [PATCH] pmdomain: starfive: Remove redundant dev_err()
@ 2026-07-16 9:22 Pan Chuang
2026-07-16 12:29 ` Ulf Hansson
0 siblings, 1 reply; 3+ messages in thread
From: Pan Chuang @ 2026-07-16 9:22 UTC (permalink / raw)
To: Walker Chen, Changhuang Liang, Ulf Hansson,
open list:GENERIC PM DOMAINS, open list
Cc: Pan Chuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/pmdomain/starfive/jh71xx-pmu.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/pmdomain/starfive/jh71xx-pmu.c b/drivers/pmdomain/starfive/jh71xx-pmu.c
index 74720c09a6e3..aff07b0f5523 100644
--- a/drivers/pmdomain/starfive/jh71xx-pmu.c
+++ b/drivers/pmdomain/starfive/jh71xx-pmu.c
@@ -276,8 +276,6 @@ static int jh7110_pmu_parse_irq(struct platform_device *pdev, struct jh71xx_pmu
ret = devm_request_irq(dev, pmu->irq, jh71xx_pmu_interrupt,
0, pdev->name, pmu);
- if (ret)
- dev_err(dev, "failed to request irq\n");
jh71xx_pmu_int_enable(pmu, JH71XX_PMU_INT_ALL_MASK & ~JH71XX_PMU_INT_PCH_FAIL, true);
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] pmdomain: starfive: Remove redundant dev_err()
2026-07-16 9:22 [PATCH] pmdomain: starfive: Remove redundant dev_err() Pan Chuang
@ 2026-07-16 12:29 ` Ulf Hansson
2026-07-17 12:09 ` Ulf Hansson
0 siblings, 1 reply; 3+ messages in thread
From: Ulf Hansson @ 2026-07-16 12:29 UTC (permalink / raw)
To: Pan Chuang
Cc: Walker Chen, Changhuang Liang, Ulf Hansson,
open list:GENERIC PM DOMAINS, open list
On Thu, Jul 16, 2026 at 11:23 AM Pan Chuang <panchuang@vivo.com> wrote:
>
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/pmdomain/starfive/jh71xx-pmu.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/pmdomain/starfive/jh71xx-pmu.c b/drivers/pmdomain/starfive/jh71xx-pmu.c
> index 74720c09a6e3..aff07b0f5523 100644
> --- a/drivers/pmdomain/starfive/jh71xx-pmu.c
> +++ b/drivers/pmdomain/starfive/jh71xx-pmu.c
> @@ -276,8 +276,6 @@ static int jh7110_pmu_parse_irq(struct platform_device *pdev, struct jh71xx_pmu
>
> ret = devm_request_irq(dev, pmu->irq, jh71xx_pmu_interrupt,
> 0, pdev->name, pmu);
> - if (ret)
> - dev_err(dev, "failed to request irq\n");
>
> jh71xx_pmu_int_enable(pmu, JH71XX_PMU_INT_ALL_MASK & ~JH71XX_PMU_INT_PCH_FAIL, true);
>
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] pmdomain: starfive: Remove redundant dev_err()
2026-07-16 12:29 ` Ulf Hansson
@ 2026-07-17 12:09 ` Ulf Hansson
0 siblings, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2026-07-17 12:09 UTC (permalink / raw)
To: Pan Chuang
Cc: Walker Chen, Changhuang Liang, Ulf Hansson,
open list:GENERIC PM DOMAINS, open list
On Thu, Jul 16, 2026 at 2:29 PM Ulf Hansson
<ulf.hansson@oss.qualcomm.com> wrote:
>
> On Thu, Jul 16, 2026 at 11:23 AM Pan Chuang <panchuang@vivo.com> wrote:
> >
> > Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> > devm_request_*_irq()"), devm_request_irq() automatically logs
> > detailed error messages on failure. Remove the now-redundant
> > driver-specific dev_err() calls.
> >
> > Signed-off-by: Pan Chuang <panchuang@vivo.com>
>
> Applied for next, thanks!
As this causes a build warning, I have dropped the $subject patch from
my next branch.
[...]
Kind regards
Uffe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-17 12:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-16 9:22 [PATCH] pmdomain: starfive: Remove redundant dev_err() Pan Chuang
2026-07-16 12:29 ` Ulf Hansson
2026-07-17 12:09 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox