* [PATCH v2 -next] keys: Remove unused extern declarations
@ 2023-07-24 14:47 YueHaibing
2023-07-28 18:55 ` Jarkko Sakkinen
0 siblings, 1 reply; 3+ messages in thread
From: YueHaibing @ 2023-07-24 14:47 UTC (permalink / raw)
To: dhowells, jarkko, paul, jmorris, serge, yuehaibing
Cc: keyrings, linux-security-module, linux-kernel
Since commit b2a4df200d57 ("KEYS: Expand the capacity of a keyring")
iterate_over_keyring() is never used, so can be removed.
And commit b5f545c880a2 ("[PATCH] keys: Permit running process to instantiate keys")
left behind keyring_search_instkey().
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
v2: Also remove keyring_search_instkey()
---
security/keys/internal.h | 7 -------
1 file changed, 7 deletions(-)
diff --git a/security/keys/internal.h b/security/keys/internal.h
index 3c1e7122076b..471cf36dedc0 100644
--- a/security/keys/internal.h
+++ b/security/keys/internal.h
@@ -109,13 +109,6 @@ extern void __key_link_end(struct key *keyring,
extern key_ref_t find_key_to_update(key_ref_t keyring_ref,
const struct keyring_index_key *index_key);
-extern struct key *keyring_search_instkey(struct key *keyring,
- key_serial_t target_id);
-
-extern int iterate_over_keyring(const struct key *keyring,
- int (*func)(const struct key *key, void *data),
- void *data);
-
struct keyring_search_context {
struct keyring_index_key index_key;
const struct cred *cred;
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2 -next] keys: Remove unused extern declarations
2023-07-24 14:47 [PATCH v2 -next] keys: Remove unused extern declarations YueHaibing
@ 2023-07-28 18:55 ` Jarkko Sakkinen
2023-07-29 2:40 ` YueHaibing
0 siblings, 1 reply; 3+ messages in thread
From: Jarkko Sakkinen @ 2023-07-28 18:55 UTC (permalink / raw)
To: YueHaibing, dhowells, paul, jmorris, serge
Cc: keyrings, linux-security-module, linux-kernel
On Mon Jul 24, 2023 at 2:47 PM UTC, YueHaibing wrote:
> Since commit b2a4df200d57 ("KEYS: Expand the capacity of a keyring")
> iterate_over_keyring() is never used, so can be removed.
>
> And commit b5f545c880a2 ("[PATCH] keys: Permit running process to instantiate keys")
> left behind keyring_search_instkey().
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Please use the fixes tag properly.
> ---
> v2: Also remove keyring_search_instkey()
> ---
> security/keys/internal.h | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/security/keys/internal.h b/security/keys/internal.h
> index 3c1e7122076b..471cf36dedc0 100644
> --- a/security/keys/internal.h
> +++ b/security/keys/internal.h
> @@ -109,13 +109,6 @@ extern void __key_link_end(struct key *keyring,
> extern key_ref_t find_key_to_update(key_ref_t keyring_ref,
> const struct keyring_index_key *index_key);
>
> -extern struct key *keyring_search_instkey(struct key *keyring,
> - key_serial_t target_id);
> -
> -extern int iterate_over_keyring(const struct key *keyring,
> - int (*func)(const struct key *key, void *data),
> - void *data);
> -
> struct keyring_search_context {
> struct keyring_index_key index_key;
> const struct cred *cred;
> --
> 2.34.1
BR, Jarkko
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2 -next] keys: Remove unused extern declarations
2023-07-28 18:55 ` Jarkko Sakkinen
@ 2023-07-29 2:40 ` YueHaibing
0 siblings, 0 replies; 3+ messages in thread
From: YueHaibing @ 2023-07-29 2:40 UTC (permalink / raw)
To: Jarkko Sakkinen, dhowells, paul, jmorris, serge
Cc: keyrings, linux-security-module, linux-kernel
On 2023/7/29 2:55, Jarkko Sakkinen wrote:
> On Mon Jul 24, 2023 at 2:47 PM UTC, YueHaibing wrote:
>> Since commit b2a4df200d57 ("KEYS: Expand the capacity of a keyring")
>> iterate_over_keyring() is never used, so can be removed.
>>
>> And commit b5f545c880a2 ("[PATCH] keys: Permit running process to instantiate keys")
>> left behind keyring_search_instkey().
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
> Please use the fixes tag properly.
OK， will add fixes tag in v3.
>
>> ---
>> v2: Also remove keyring_search_instkey()
>> ---
>> security/keys/internal.h | 7 -------
>> 1 file changed, 7 deletions(-)
>>
>> diff --git a/security/keys/internal.h b/security/keys/internal.h
>> index 3c1e7122076b..471cf36dedc0 100644
>> --- a/security/keys/internal.h
>> +++ b/security/keys/internal.h
>> @@ -109,13 +109,6 @@ extern void __key_link_end(struct key *keyring,
>> extern key_ref_t find_key_to_update(key_ref_t keyring_ref,
>> const struct keyring_index_key *index_key);
>>
>> -extern struct key *keyring_search_instkey(struct key *keyring,
>> - key_serial_t target_id);
>> -
>> -extern int iterate_over_keyring(const struct key *keyring,
>> - int (*func)(const struct key *key, void *data),
>> - void *data);
>> -
>> struct keyring_search_context {
>> struct keyring_index_key index_key;
>> const struct cred *cred;
>> --
>> 2.34.1
>
>
> BR, Jarkko
> .
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-29 2:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-24 14:47 [PATCH v2 -next] keys: Remove unused extern declarations YueHaibing
2023-07-28 18:55 ` Jarkko Sakkinen
2023-07-29 2:40 ` YueHaibing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®