mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Eric Snowberg" <eric.snowberg@oracle.com>, <dhowells@redhat.com>,
	<dwmw2@infradead.org>
Cc: <zohar@linux.ibm.com>, <keyrings@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <kanth.ghatraju@oracle.com>,
	<konrad.wilk@oracle.com>
Subject: Re: [PATCH v2] certs: Reference revocation list for all keyrings
Date: Thu, 17 Aug 2023 18:54:23 +0000	[thread overview]
Message-ID: <CUV1QLCMZTDX.3ACSGPQ4OY870@seitikki> (raw)
In-Reply-To: <20230817140407.1599240-1-eric.snowberg@oracle.com>

On Thu Aug 17, 2023 at 2:04 PM UTC, Eric Snowberg wrote:
> Systems booted with shim have a Forbidden Signature Database called mokx.
> During boot, hashes and certs contained within the mokx are loaded into the
> blacklist keyring.  When calling verify_pkcs7_message_sig the contents of
> the blacklist keyring (or revocation list) are referenced when validating
> keys on the platform keyring. Currently, when validating against the
> secondary or builtin keyrings, the revocation list is not referenced.  Move
> up the check to allow the revocation list to be used with all keyrings,
> including the secondary and builtin, allowing the system owner to take
> corrective action should a vulnerability be found within keys contained
> within either keyring.
>
> Signed-off-by: Eric Snowberg <eric.snowberg@oracle.com>
> Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
> Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
> ---
> v2 changes:
> Since this one seems to have been forgotten, added the two Reviewed-by tags.
> Unless there are any objections, could this be picked up?

Applied to -next.

BR, Jarkko

      reply	other threads:[~2023-08-17 18:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-17 14:04 Eric Snowberg
2023-08-17 18:54 ` Jarkko Sakkinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CUV1QLCMZTDX.3ACSGPQ4OY870@seitikki \
    --to=jarkko@kernel.org \
    --cc=dhowells@redhat.com \
    --cc=dwmw2@infradead.org \
    --cc=eric.snowberg@oracle.com \
    --cc=kanth.ghatraju@oracle.com \
    --cc=keyrings@vger.kernel.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®