* [PATCH] tools cpupower bench: Override CFLAGS assignments
@ 2023-11-24 18:50 Stanley Chan
2023-11-24 18:59 ` Stanley Chan
0 siblings, 1 reply; 3+ messages in thread
From: Stanley Chan @ 2023-11-24 18:50 UTC (permalink / raw)
To: linux-pm
Cc: kernel-team, Stanley Chan, Thomas Renninger, Shuah Khan, linux-kernel
Allow user to specify outside CFLAGS values as make argument
Corrects an issue where CFLAGS is passed as a make argument for
cpupower, but bench's makefile does not inherit and append to them.
see also:
commit dbc4ca339c8d ("tools cpupower: Override CFLAGS assignments")
Signed-off-by: Stanley Chan <schan@cloudflare.com>
---
tools/power/cpupower/bench/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/power/cpupower/bench/Makefile b/tools/power/cpupower/bench/Makefile
index d9d9923af85c..a4b902f9e1c4 100644
--- a/tools/power/cpupower/bench/Makefile
+++ b/tools/power/cpupower/bench/Makefile
@@ -15,7 +15,7 @@ LIBS = -L../ -L$(OUTPUT) -lm -lcpupower
OBJS = $(OUTPUT)main.o $(OUTPUT)parse.o $(OUTPUT)system.o $(OUTPUT)benchmark.o
endif
-CFLAGS += -D_GNU_SOURCE -I../lib -DDEFAULT_CONFIG_FILE=\"$(confdir)/cpufreq-bench.conf\"
+override CFLAGS += -D_GNU_SOURCE -I../lib -DDEFAULT_CONFIG_FILE=\"$(confdir)/cpufreq-bench.conf\"
$(OUTPUT)%.o : %.c
$(ECHO) " CC " $@
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tools cpupower bench: Override CFLAGS assignments
2023-11-24 18:50 [PATCH] tools cpupower bench: Override CFLAGS assignments Stanley Chan
@ 2023-11-24 18:59 ` Stanley Chan
2023-11-27 21:09 ` Shuah Khan
0 siblings, 1 reply; 3+ messages in thread
From: Stanley Chan @ 2023-11-24 18:59 UTC (permalink / raw)
To: Stanley Chan, linux-pm
Cc: kernel-team, Thomas Renninger, Shuah Khan, linux-kernel
Apologies, this is my first patch so I'm still learning.
Meant to add
Fixes: dbc4ca339c8d ("tools cpupower: Override CFLAGS assignments")
---
Stan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tools cpupower bench: Override CFLAGS assignments
2023-11-24 18:59 ` Stanley Chan
@ 2023-11-27 21:09 ` Shuah Khan
0 siblings, 0 replies; 3+ messages in thread
From: Shuah Khan @ 2023-11-27 21:09 UTC (permalink / raw)
To: Stanley Chan, linux-pm
Cc: kernel-team, Thomas Renninger, Shuah Khan, linux-kernel, Shuah Khan
On 11/24/23 11:59, Stanley Chan wrote:
> Apologies, this is my first patch so I'm still learning.
> Meant to add
>
> Fixes: dbc4ca339c8d ("tools cpupower: Override CFLAGS assignments")
>
Thank you for the fix. Please send me v2 with this fixes tag.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-27 21:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-24 18:50 [PATCH] tools cpupower bench: Override CFLAGS assignments Stanley Chan
2023-11-24 18:59 ` Stanley Chan
2023-11-27 21:09 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®