From: "Handrigan, Paul" <Paul.Handrigan@cirrus.com>
To: Fabian Frederick <fabf@skynet.be>, Nicolin Chen <nicoleotsuka@gmail.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"broonie@kernel.org" <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [alsa-devel] [PATCH V2 linux-next] ASoC: cs53l30: include gpio/consumer.h
Date: Mon, 6 Jun 2016 17:30:31 +0000 [thread overview]
Message-ID: <D37B1CA7.14680%Paul.Handrigan@cirrus.com> (raw)
In-Reply-To: <1465232753-32492-1-git-send-email-fabf@skynet.be>
On 6/6/16, 12:05 PM, "Fabian Frederick" <fabf@skynet.be> wrote:
>cs53l30 breaks kernel compilation when CONFIG_GPIOLIB is disabled.
>
>sound/soc/codecs/cs53l30.c:931:2: error: implicit declaration of
>function devm_gpiod_get_optional [-Werror=implicit-function-declaration]
> cs53l30->reset_gpio = devm_gpiod_get_optional(dev, "reset",
> ^
>sound/soc/codecs/cs53l30.c:932:13: error: GPIOD_OUT_LOW undeclared
>(first use in this function)
>
>Including gpio/consumer.h declares minimal functions in that case.
>
>Signed-off-by: Fabian Frederick <fabf@skynet.be>
>---
>V2:
> Add in alphabetical order (suggested by Nicolin Chen)
>
> sound/soc/codecs/cs53l30.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/sound/soc/codecs/cs53l30.c b/sound/soc/codecs/cs53l30.c
>index ac90dd7..4f6ede9 100644
>--- a/sound/soc/codecs/cs53l30.c
>+++ b/sound/soc/codecs/cs53l30.c
>@@ -14,6 +14,7 @@
>
> #include <linux/clk.h>
> #include <linux/delay.h>
>+#include <linux/gpio/consumer.h>
> #include <linux/i2c.h>
> #include <linux/module.h>
> #include <linux/of_gpio.h>
>--
>2.1.4
Thanks!
Acked-by: Paul Handrigan <Paul.Handrigan@cirrus.com>
next prev parent reply other threads:[~2016-06-06 17:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 17:05 Fabian Frederick
2016-06-06 17:30 ` Handrigan, Paul [this message]
2016-06-06 17:36 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D37B1CA7.14680%Paul.Handrigan@cirrus.com \
--to=paul.handrigan@cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=fabf@skynet.be \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicoleotsuka@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®