From: "Handrigan, Paul" <Paul.Handrigan@cirrus.com>
To: Nicolin Chen <nicoleotsuka@gmail.com>,
"broonie@kernel.org" <broonie@kernel.org>
Cc: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"Austin, Brian" <Brian.Austin@cirrus.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] ASoC: cs53l30: Set idle_bias_off true
Date: Mon, 20 Jun 2016 15:35:51 +0000 [thread overview]
Message-ID: <D38D7758.14D0B%Paul.Handrigan@cirrus.com> (raw)
In-Reply-To: <1466213517-18523-1-git-send-email-nicoleotsuka@gmail.com>
On 6/17/16, 8:31 PM, "Nicolin Chen" <nicoleotsuka@gmail.com> wrote:
>The driver is using the set_bias_level to control the power on and
>off so it should get SND_SOC_BIAS_OFF in order to proceed normal
>powering sequences. This patch enables the idle_bias_off option so
>the DAPM core will set the bias level to SND_SOC_BIAS_OFF instead
>of stopping at SND_SOC_BIAS_STANDBY.
>
>Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
>---
> sound/soc/codecs/cs53l30.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/sound/soc/codecs/cs53l30.c b/sound/soc/codecs/cs53l30.c
>index a5976f3..b0a64a1 100644
>--- a/sound/soc/codecs/cs53l30.c
>+++ b/sound/soc/codecs/cs53l30.c
>@@ -879,6 +879,7 @@ static int cs53l30_codec_probe(struct snd_soc_codec
>*codec)
> static struct snd_soc_codec_driver cs53l30_driver = {
> .probe = cs53l30_codec_probe,
> .set_bias_level = cs53l30_set_bias_level,
>+ .idle_bias_off = true,
>
> .dapm_widgets = cs53l30_dapm_widgets,
> .num_dapm_widgets = ARRAY_SIZE(cs53l30_dapm_widgets),
>--
>2.1.4
Thanks!
Acked-by: Paul Handrigan <Paul.Handrigan@cirrus.com>
>
next prev parent reply other threads:[~2016-06-20 15:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-18 1:31 Nicolin Chen
2016-06-20 15:35 ` Handrigan, Paul [this message]
2016-06-21 18:52 ` Applied "ASoC: cs53l30: Set idle_bias_off true" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D38D7758.14D0B%Paul.Handrigan@cirrus.com \
--to=paul.handrigan@cirrus.com \
--cc=Brian.Austin@cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicoleotsuka@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®