From: Thorsten Blum <thorsten.blum@linux.dev>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Huisong Li <lihuisong@huawei.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] w1: therm: Use str_yes_no helper in w1_slave_show
Date: Sat, 8 Nov 2025 16:07:02 +0100 [thread overview]
Message-ID: <D43F162D-588C-418F-A019-B50BE1D0F92C@linux.dev> (raw)
In-Reply-To: <9502638c-1058-4a82-934b-87d4995ec8b2@kernel.org>
On 5. Nov 2025, at 17:23, Krzysztof Kozlowski wrote:
> On 05/11/2025 17:18, Thorsten Blum wrote:
>> Replace hard-coded strings with the str_yes_no() helper function. This
>> unifies the output and helps the linker with deduplication, which can
>> result in a smaller binary.
>>
>> [...]
>
> That's sysfs interface, right? So an ABI and you change here caps, which
> might matter or might not, but anyway some sort of analysis of that
> should be in the commit msg. Otherwise better not to touch ABI.
Yeah, I guess it's better not to change it then.
Thanks,
Thorsten
prev parent reply other threads:[~2025-11-08 15:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 16:18 Thorsten Blum
2025-11-05 16:23 ` Krzysztof Kozlowski
2025-11-08 15:07 ` Thorsten Blum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D43F162D-588C-418F-A019-B50BE1D0F92C@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=krzk@kernel.org \
--cc=lihuisong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®