[PATCH] w1: therm: Use str_yes_no helper in w1_slave_show

[PATCH] w1: therm: Use str_yes_no helper in w1_slave_show

[Thorsten Blum]

Replace hard-coded strings with the str_yes_no() helper function. This
unifies the output and helps the linker with deduplication, which can
result in a smaller binary.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 drivers/w1/slaves/w1_therm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/w1/slaves/w1_therm.c b/drivers/w1/slaves/w1_therm.c
index 9ccedb3264fb..0b54ab7f237e 100644
--- a/drivers/w1/slaves/w1_therm.c
+++ b/drivers/w1/slaves/w1_therm.c
@@ -17,6 +17,7 @@
 #include <linux/delay.h>
 #include <linux/hwmon.h>
 #include <linux/string.h>
+#include <linux/string_choices.h>
 #include <linux/jiffies.h>
 
 #include <linux/w1.h>
@@ -1609,7 +1610,7 @@ static ssize_t w1_slave_show(struct device *device,
 	for (i = 0; i < 9; ++i)
 		c -= snprintf(buf + PAGE_SIZE - c, c, "%02x ", info.rom[i]);
 	c -= snprintf(buf + PAGE_SIZE - c, c, ": crc=%02x %s\n",
-		      info.crc, (info.verdict) ? "YES" : "NO");
+		      info.crc, str_yes_no(info.verdict));
 
 	if (info.verdict)
 		memcpy(family_data, info.rom, sizeof(info.rom));
-- 
2.51.1

Re: [PATCH] w1: therm: Use str_yes_no helper in w1_slave_show

[Krzysztof Kozlowski]

On 05/11/2025 17:18, Thorsten Blum wrote:
> Replace hard-coded strings with the str_yes_no() helper function. This
> unifies the output and helps the linker with deduplication, which can
> result in a smaller binary.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
>  drivers/w1/slaves/w1_therm.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/w1/slaves/w1_therm.c b/drivers/w1/slaves/w1_therm.c
> index 9ccedb3264fb..0b54ab7f237e 100644
> --- a/drivers/w1/slaves/w1_therm.c
> +++ b/drivers/w1/slaves/w1_therm.c
> @@ -17,6 +17,7 @@
>  #include <linux/delay.h>
>  #include <linux/hwmon.h>
>  #include <linux/string.h>
> +#include <linux/string_choices.h>
>  #include <linux/jiffies.h>
>  
>  #include <linux/w1.h>
> @@ -1609,7 +1610,7 @@ static ssize_t w1_slave_show(struct device *device,
>  	for (i = 0; i < 9; ++i)
>  		c -= snprintf(buf + PAGE_SIZE - c, c, "%02x ", info.rom[i]);
>  	c -= snprintf(buf + PAGE_SIZE - c, c, ": crc=%02x %s\n",
> -		      info.crc, (info.verdict) ? "YES" : "NO");

That's sysfs interface, right? So an ABI and you change here caps, which
might matter or might not, but anyway some sort of analysis of that
should be in the commit msg. Otherwise better not to touch ABI.

Best regards,
Krzysztof

Re: [PATCH] w1: therm: Use str_yes_no helper in w1_slave_show

[Thorsten Blum]

On 5. Nov 2025, at 17:23, Krzysztof Kozlowski wrote:
> On 05/11/2025 17:18, Thorsten Blum wrote:
>> Replace hard-coded strings with the str_yes_no() helper function. This
>> unifies the output and helps the linker with deduplication, which can
>> result in a smaller binary.
>> 
>> [...]
> 
> That's sysfs interface, right? So an ABI and you change here caps, which
> might matter or might not, but anyway some sort of analysis of that
> should be in the commit msg. Otherwise better not to touch ABI.

Yeah, I guess it's better not to change it then.

Thanks,
Thorsten