* [PATCH] arm64: dts: qcom: qcs6460-rb3gen2: enable venus node
@ 2024-09-17 9:24 Vedang Nagar via B4 Relay
2024-09-17 14:06 ` Dmitry Baryshkov
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Vedang Nagar via B4 Relay @ 2024-09-17 9:24 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Vedang Nagar
From: Vedang Nagar <quic_vnagar@quicinc.com>
Enable the venus node on Qualcomm Rb3gen2 so that the
video decoder will start working.
Signed-off-by: Vedang Nagar <quic_vnagar@quicinc.com>
---
arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
index 0d45662b8028bff475024cff37c33e01d2ee251b..d52a7e0a35bf941c66ccaa00425147781976b359 100644
--- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
+++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
@@ -790,6 +790,10 @@ &ufs_mem_phy {
status = "okay";
};
+&venus {
+ status = "okay";
+};
+
&wifi {
memory-region = <&wlan_fw_mem>;
};
---
base-commit: 3f52e32445a1f63b788bc8969b7dc2386a80a24d
change-id: 20240917-venus_rb3_gen2-502e672d0e20
prerequisite-change-id: 20240913-qcm6490-clock-configs-0239f30babb5:v1
prerequisite-patch-id: faac726ebdf08240ab0913132beb2c620e52a98a
Best regards,
--
Vedang Nagar <quic_vnagar@quicinc.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: qcs6460-rb3gen2: enable venus node
2024-09-17 9:24 [PATCH] arm64: dts: qcom: qcs6460-rb3gen2: enable venus node Vedang Nagar via B4 Relay
@ 2024-09-17 14:06 ` Dmitry Baryshkov
2024-09-18 7:38 ` Luca Weiss
2024-10-07 14:26 ` Bjorn Andersson
2 siblings, 0 replies; 5+ messages in thread
From: Dmitry Baryshkov @ 2024-09-17 14:06 UTC (permalink / raw)
To: quic_vnagar
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel
On Tue, Sep 17, 2024 at 02:54:31PM GMT, Vedang Nagar via B4 Relay wrote:
> From: Vedang Nagar <quic_vnagar@quicinc.com>
>
> Enable the venus node on Qualcomm Rb3gen2 so that the
> video decoder will start working.
>
> Signed-off-by: Vedang Nagar <quic_vnagar@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 4 ++++
> 1 file changed, 4 insertions(+)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: qcs6460-rb3gen2: enable venus node
2024-09-17 9:24 [PATCH] arm64: dts: qcom: qcs6460-rb3gen2: enable venus node Vedang Nagar via B4 Relay
2024-09-17 14:06 ` Dmitry Baryshkov
@ 2024-09-18 7:38 ` Luca Weiss
2024-09-18 11:15 ` Vedang Nagar
2024-10-07 14:26 ` Bjorn Andersson
2 siblings, 1 reply; 5+ messages in thread
From: Luca Weiss @ 2024-09-18 7:38 UTC (permalink / raw)
To: quic_vnagar, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
Hi Vedang!
On Tue Sep 17, 2024 at 11:24 AM CEST, Vedang Nagar via B4 Relay wrote:
> From: Vedang Nagar <quic_vnagar@quicinc.com>
>
> Enable the venus node on Qualcomm Rb3gen2 so that the
> video decoder will start working.
>
> Signed-off-by: Vedang Nagar <quic_vnagar@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> index 0d45662b8028bff475024cff37c33e01d2ee251b..d52a7e0a35bf941c66ccaa00425147781976b359 100644
> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> @@ -790,6 +790,10 @@ &ufs_mem_phy {
> status = "okay";
> };
>
> +&venus {
> + status = "okay";
Don't you want to set firmware-name property here?
Regards
Luca
> +};
> +
> &wifi {
> memory-region = <&wlan_fw_mem>;
> };
>
> ---
> base-commit: 3f52e32445a1f63b788bc8969b7dc2386a80a24d
> change-id: 20240917-venus_rb3_gen2-502e672d0e20
> prerequisite-change-id: 20240913-qcm6490-clock-configs-0239f30babb5:v1
> prerequisite-patch-id: faac726ebdf08240ab0913132beb2c620e52a98a
>
> Best regards,
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: qcs6460-rb3gen2: enable venus node
2024-09-18 7:38 ` Luca Weiss
@ 2024-09-18 11:15 ` Vedang Nagar
0 siblings, 0 replies; 5+ messages in thread
From: Vedang Nagar @ 2024-09-18 11:15 UTC (permalink / raw)
To: Luca Weiss, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
Hi Luca,
On 9/18/2024 1:08 PM, Luca Weiss wrote:
> Hi Vedang!
>
> On Tue Sep 17, 2024 at 11:24 AM CEST, Vedang Nagar via B4 Relay wrote:
>> From: Vedang Nagar <quic_vnagar@quicinc.com>
>>
>> Enable the venus node on Qualcomm Rb3gen2 so that the
>> video decoder will start working.
>>
>> Signed-off-by: Vedang Nagar <quic_vnagar@quicinc.com>
>> ---
>> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>> index 0d45662b8028bff475024cff37c33e01d2ee251b..d52a7e0a35bf941c66ccaa00425147781976b359 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>> @@ -790,6 +790,10 @@ &ufs_mem_phy {
>> status = "okay";
>> };
>>
>> +&venus {
>> + status = "okay";
>
> Don't you want to set firmware-name property here?
No, we don't need to set firmware-name property here, it will pick the default path from:
https://elixir.bootlin.com/linux/v6.11/source/drivers/media/platform/qcom/venus/core.c#L932
Regards,
Vedang Nagar
>
> Regards
> Luca
>
>> +};
>> +
>> &wifi {
>> memory-region = <&wlan_fw_mem>;
>> };
>>
>> ---
>> base-commit: 3f52e32445a1f63b788bc8969b7dc2386a80a24d
>> change-id: 20240917-venus_rb3_gen2-502e672d0e20
>> prerequisite-change-id: 20240913-qcm6490-clock-configs-0239f30babb5:v1
>> prerequisite-patch-id: faac726ebdf08240ab0913132beb2c620e52a98a
>>
>> Best regards,
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: qcs6460-rb3gen2: enable venus node
2024-09-17 9:24 [PATCH] arm64: dts: qcom: qcs6460-rb3gen2: enable venus node Vedang Nagar via B4 Relay
2024-09-17 14:06 ` Dmitry Baryshkov
2024-09-18 7:38 ` Luca Weiss
@ 2024-10-07 14:26 ` Bjorn Andersson
2 siblings, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2024-10-07 14:26 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Konrad Dybcio,
Vedang Nagar
Cc: linux-arm-msm, devicetree, linux-kernel
On Tue, 17 Sep 2024 14:54:31 +0530, Vedang Nagar wrote:
> Enable the venus node on Qualcomm Rb3gen2 so that the
> video decoder will start working.
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: qcs6460-rb3gen2: enable venus node
commit: 17a809b35dd9542a46296e80e7dadd88849e73e9
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-10-07 14:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-17 9:24 [PATCH] arm64: dts: qcom: qcs6460-rb3gen2: enable venus node Vedang Nagar via B4 Relay
2024-09-17 14:06 ` Dmitry Baryshkov
2024-09-18 7:38 ` Luca Weiss
2024-09-18 11:15 ` Vedang Nagar
2024-10-07 14:26 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®