From: "Malavali, Giridhar" <Giridhar.Malavali@cavium.com>
To: Julia Lawall <julia.lawall@lip6.fr>,
Johannes Thumshirn <jthumshirn@suse.de>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
Linux SCSI Mailinglist <linux-scsi@vger.kernel.org>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Dept-Eng QLA2xxx Upstream <qla2xxx-upstream@cavium.com>,
"Madhani, Himanshu" <Himanshu.Madhani@cavium.com>,
Johannes Thumshirn <jthumshirn@suse.de>,
Linux SCSI Mailinglist <linux-scsi@vger.kernel.org>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
Dept-Eng QLA2xxx Upstream <qla2xxx-upstream@cavium.com>,
"Madhani, Himanshu" <Himanshu.Madhani@cavium.com>,
Johannes Thumshirn <jthumshirn@suse.de>
Subject: Re: [PATCH] qla2xxx: Protect access to qpair members with qpair->qp_lock
Date: Fri, 23 Jun 2017 22:04:26 +0000 [thread overview]
Message-ID: <D572DE61.976AF%giridhar.malavali@cavium.com> (raw)
Yes, it¹s needed. We will post a patch.
On 6/23/17, 9:34 AM, "Julia Lawall" <julia.lawall@lip6.fr> wrote:
>Please check on whether an unlock is neeed before line 1965.
>
>julia
>
>---------- Forwarded message ----------
>Date: Fri, 23 Jun 2017 15:23:00 +0800
>From: kbuild test robot <fengguang.wu@intel.com>
>To: kbuild@01.org
>Cc: Julia Lawall <julia.lawall@lip6.fr>
>Subject: Re: [PATCH] qla2xxx: Protect access to qpair members with
> qpair->qp_lock
>
>CC: kbuild-all@01.org
>In-Reply-To: <20170622134325.26931-1-jthumshirn@suse.de>
>
>Hi Johannes,
>
>[auto build test WARNING on scsi/for-next]
>[also build test WARNING on v4.12-rc6 next-20170622]
>[if your patch is applied to the wrong git tree, please drop us a note to
>help improve the system]
>
>url:
>https://github.com/0day-ci/linux/commits/Johannes-Thumshirn/qla2xxx-Protec
>t-access-to-qpair-members-with-qpair-qp_lock/20170623-123844
>base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git
>for-next
>:::::: branch date: 3 hours ago
>:::::: commit date: 3 hours ago
>
>>> drivers/scsi/qla2xxx/qla_iocb.c:1965:3-9: preceding lock on line 1952
>
>git remote add linux-review https://github.com/0day-ci/linux
>git remote update linux-review
>git checkout 4a35d720268dbe9ac016957a3c4fc644398d68ba
>vim +1965 drivers/scsi/qla2xxx/qla_iocb.c
>
>d74595278 Michael Hernandez 2016-12-12 1946 /* Only process
>protection or >16 cdb in this routine */
>d74595278 Michael Hernandez 2016-12-12 1947 if (scsi_get_prot_op(cmd)
>== SCSI_PROT_NORMAL) {
>d74595278 Michael Hernandez 2016-12-12 1948 if (cmd->cmd_len <= 16)
>d74595278 Michael Hernandez 2016-12-12 1949 return
>qla2xxx_start_scsi_mq(sp);
>d74595278 Michael Hernandez 2016-12-12 1950 }
>d74595278 Michael Hernandez 2016-12-12 1951
>4a35d7202 Johannes Thumshirn 2017-06-22 @1952
> spin_lock_irqsave(&qpair->qp_lock, flags);
>4a35d7202 Johannes Thumshirn 2017-06-22 1953
>d74595278 Michael Hernandez 2016-12-12 1954 /* Setup qpair pointers */
>d74595278 Michael Hernandez 2016-12-12 1955 rsp = qpair->rsp;
>d74595278 Michael Hernandez 2016-12-12 1956 req = qpair->req;
>d74595278 Michael Hernandez 2016-12-12 1957
>d74595278 Michael Hernandez 2016-12-12 1958 /* So we know we haven't
>pci_map'ed anything yet */
>d74595278 Michael Hernandez 2016-12-12 1959 tot_dsds = 0;
>d74595278 Michael Hernandez 2016-12-12 1960
>d74595278 Michael Hernandez 2016-12-12 1961 /* Send marker if
>required */
>d74595278 Michael Hernandez 2016-12-12 1962 if (vha->marker_needed !=
>0) {
>d74595278 Michael Hernandez 2016-12-12 1963 if (qla2x00_marker(vha,
>req, rsp, 0, 0, MK_SYNC_ALL) !=
>d74595278 Michael Hernandez 2016-12-12 1964 QLA_SUCCESS)
>d74595278 Michael Hernandez 2016-12-12 @1965 return
>QLA_FUNCTION_FAILED;
>d74595278 Michael Hernandez 2016-12-12 1966 vha->marker_needed = 0;
>d74595278 Michael Hernandez 2016-12-12 1967 }
>d74595278 Michael Hernandez 2016-12-12 1968
>
>:::::: The code at line 1965 was first introduced by commit
>:::::: d74595278f4ab192af66d9e60a9087464638beee scsi: qla2xxx: Add
>multiple queue pair functionality.
>
>:::::: TO: Michael Hernandez <michael.hernandez@cavium.com>
>:::::: CC: Martin K. Petersen <martin.petersen@oracle.com>
>
>---
>0-DAY kernel test infrastructure Open Source Technology
>Center
>https://lists.01.org/pipermail/kbuild-all Intel
>Corporation
next reply other threads:[~2017-06-23 22:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 22:04 Malavali, Giridhar [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-06-22 13:43 Johannes Thumshirn
2017-06-22 13:53 ` Hannes Reinecke
2017-06-22 14:19 ` John Garry
2017-06-22 14:23 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D572DE61.976AF%giridhar.malavali@cavium.com \
--to=giridhar.malavali@cavium.com \
--cc=Himanshu.Madhani@cavium.com \
--cc=jthumshirn@suse.de \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=qla2xxx-upstream@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®