* [PATCH] i2c: nomadik: Add missing sentinel to match table
@ 2024-12-06 8:28 Geert Uytterhoeven
2024-12-06 8:35 ` Théo Lebrun
2024-12-10 18:59 ` Andi Shyti
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2024-12-06 8:28 UTC (permalink / raw)
To: Théo Lebrun, Linus Walleij, Andi Shyti, Wolfram Sang
Cc: linux-i2c, linux-arm-kernel, linux-kernel, Geert Uytterhoeven
The OF match table is not NULL-terminated.
Fix this by adding a sentinel to nmk_i2c_eyeq_match_table[].
Fixes: a0d15cc47f29be6d ("i2c: nomadik: switch from of_device_is_compatible() to of_match_device()")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/i2c/busses/i2c-nomadik.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c
index efb33802804fdde8..d2877e4cc28d42c9 100644
--- a/drivers/i2c/busses/i2c-nomadik.c
+++ b/drivers/i2c/busses/i2c-nomadik.c
@@ -1075,6 +1075,7 @@ static const struct of_device_id nmk_i2c_eyeq_match_table[] = {
.compatible = "mobileye,eyeq6h-i2c",
.data = (void *)NMK_I2C_EYEQ_FLAG_32B_BUS,
},
+ { /* sentinel */ }
};
static int nmk_i2c_probe(struct amba_device *adev, const struct amba_id *id)
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: nomadik: Add missing sentinel to match table
2024-12-06 8:28 [PATCH] i2c: nomadik: Add missing sentinel to match table Geert Uytterhoeven
@ 2024-12-06 8:35 ` Théo Lebrun
2024-12-10 18:59 ` Andi Shyti
1 sibling, 0 replies; 3+ messages in thread
From: Théo Lebrun @ 2024-12-06 8:35 UTC (permalink / raw)
To: Geert Uytterhoeven, Linus Walleij, Andi Shyti, Wolfram Sang
Cc: linux-i2c, linux-arm-kernel, linux-kernel
Hello Geert & all,
On Fri Dec 6, 2024 at 9:28 AM CET, Geert Uytterhoeven wrote:
> The OF match table is not NULL-terminated.
> Fix this by adding a sentinel to nmk_i2c_eyeq_match_table[].
I had the exact same patch pending locally. Sorry and thanks!
Reviewed-by: Théo Lebrun <theo.lebrun@bootlin.com>
Thanks,
--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: nomadik: Add missing sentinel to match table
2024-12-06 8:28 [PATCH] i2c: nomadik: Add missing sentinel to match table Geert Uytterhoeven
2024-12-06 8:35 ` Théo Lebrun
@ 2024-12-10 18:59 ` Andi Shyti
1 sibling, 0 replies; 3+ messages in thread
From: Andi Shyti @ 2024-12-10 18:59 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Théo Lebrun, Linus Walleij, Wolfram Sang, linux-i2c,
linux-arm-kernel, linux-kernel
Hi Geert,
On Fri, Dec 06, 2024 at 09:28:06AM +0100, Geert Uytterhoeven wrote:
> The OF match table is not NULL-terminated.
> Fix this by adding a sentinel to nmk_i2c_eyeq_match_table[].
>
> Fixes: a0d15cc47f29be6d ("i2c: nomadik: switch from of_device_is_compatible() to of_match_device()")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
merged to i2c/i2c-host-fixes.
Thanks,
Andi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-12-10 18:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-12-06 8:28 [PATCH] i2c: nomadik: Add missing sentinel to match table Geert Uytterhoeven
2024-12-06 8:35 ` Théo Lebrun
2024-12-10 18:59 ` Andi Shyti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®