From: "Drokin, Oleg" <oleg.drokin@intel.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: "<kernel-janitors@vger.kernel.org>"
<kernel-janitors@vger.kernel.org>,
"Dilger, Andreas" <andreas.dilger@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"<HPDD-discuss@lists.01.org>" <HPDD-discuss@ml01.01.org>,
"<devel@driverdev.osuosl.org>" <devel@driverdev.osuosl.org>,
"<linux-kernel@vger.kernel.org>" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: lustre: obd_support: Add obd_cpt_alloc function
Date: Sat, 2 May 2015 21:38:53 +0000 [thread overview]
Message-ID: <D7D0EE01-6BD2-498F-88D5-CC3829A39561@intel.com> (raw)
In-Reply-To: <1430601408-12847-1-git-send-email-Julia.Lawall@lip6.fr>
On May 2, 2015, at 5:16 PM, Julia Lawall wrote:
> Summarize OBD_CPT_ALLOC_GFP, OBD_CPT_ALLOC, and OBD_CPT_ALLOC_PTR as a
> function, obd_cpt_alloc.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
>
> Some questions: Is the name OK? Is the NULL test needed? If not, should
> the call to kzalloc_node with the call to cfs_cpt_spread_node just be
> inlined into the call sites?
I think we don't need this function at all, we can use kzalloc/kzalloc_node directly with cfs_cpt_spread_node call in.
What we do need is obd_cpt_alloc_large similar to how we need obd_alloc_large (I know I still owe you a proper patch with that).
The only differences between the two would then be passing down of the cpt (and it's use) or not.
Bye,
Oleg
next prev parent reply other threads:[~2015-05-02 21:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-02 21:16 Julia Lawall
2015-05-02 21:38 ` Drokin, Oleg [this message]
2015-05-03 5:53 ` Julia Lawall
2015-05-03 10:29 ` Drokin, Oleg
2015-05-02 21:47 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D7D0EE01-6BD2-498F-88D5-CC3829A39561@intel.com \
--to=oleg.drokin@intel.com \
--cc=HPDD-discuss@ml01.01.org \
--cc=Julia.Lawall@lip6.fr \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®