platform/x86: thinkpad_acpi causing kernel oops commit 38b9ab80db31cf993a8f3ab2baf772083b62ca6f

platform/x86: thinkpad_acpi causing kernel oops commit 38b9ab80db31cf993a8f3ab2baf772083b62ca6f

[Jeff Chua]

This commit prevents the latest linux git from booting. Only those
with thinkpad-acpi will see this.
There's no clean way to revert this. I took the thinkpad_acpi.c from
vanilla 6.14.0 and that booted up with the latest linux git
(4e82c87058f45e79eeaa4d5bcc3b38dd3dce7209).




commit 38b9ab80db31cf993a8f3ab2baf772083b62ca6f
Author: Kurt Borja <kuurtb@gmail.com>
Date:   Fri Feb 14 19:03:01 2025 -0500

    platform/x86: thinkpad_acpi: Move subdriver initialization to
tpacpi_pdriver's probe.

    It was reported that if subdrivers assigned devres resources inside
    ibm_init_struct's .init callbacks, driver binding would fail with the
    following error message:

            platform thinkpad_acpi: Resources present before probing

    Let the driver core manage the lifetimes of the subdrivers and children
    devices, by initializing them inside tpacpi_driver's .probe callback.
    This is appropriate because these subdrivers usually expose sysfs groups
    and the driver core manages this automatically to avoid races.

    One immediate benefit of this, is that we are now able to use devres
    inside .init subdriver callbacks.

    platform_create_bundle is specifically used because it makes the
    driver's probe type synchronous and returns an ERR_PTR if attachment
    failed.

    Additionally, to make error handling simpler, allocate the input device
    using devm_input_allocate_device().

    Reported-by: Mark Pearson <mpearson-lenovo@squebb.ca>
    Closes: https://lore.kernel.org/platform-driver-x86/20250208091438.5972-1-mpearson-lenovo@squebb.ca/#t
    Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
    Tested-by: Mark Pearson <mpearson-lenovo@squebb.ca>
    Signed-off-by: Kurt Borja <kuurtb@gmail.com>
    Link: https://lore.kernel.org/r/20250215000302.19753-2-kuurtb@gmail.com
    Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>



My best.,
Jeff

Re: platform/x86: thinkpad_acpi causing kernel oops commit 38b9ab80db31cf993a8f3ab2baf772083b62ca6f

[Kurt Borja]

Hi Jeff,

On Mon Mar 31, 2025 at 4:51 AM -03, Jeff Chua wrote:
> This commit prevents the latest linux git from booting. Only those
> with thinkpad-acpi will see this.
> There's no clean way to revert this. I took the thinkpad_acpi.c from
> vanilla 6.14.0 and that booted up with the latest linux git
> (4e82c87058f45e79eeaa4d5bcc3b38dd3dce7209).

I submitted a fix for this that you can test here:

	https://lore.kernel.org/platform-driver-x86/20250330-thinkpad-fix-v1-1-4906b3fe6b74@gmail.com/

Thank you for reporting!

-- 
 ~ Kurt

Re: platform/x86: thinkpad_acpi causing kernel oops commit 38b9ab80db31cf993a8f3ab2baf772083b62ca6f

[Genes Lists]

[-- Attachment #1: Type: text/plain, Size: 401 bytes --]

On Mon, 2025-03-31 at 09:24 -0300, Kurt Borja wrote:
> 
> I submitted a fix for this that you can test here:
> 
>  https://lore.kernel.org/platform-driver-x86/20250330-thinkpad-fix-
> v1-1-4906b3fe6b74@gmail.com/
> 

FYI - Confirm it fixes the problem here as well - tested on mainline
commit 4e82c87058f45e79eeaa4d5bcc3b38dd3dce7209

 Tested-by: Gene C <arch@sapience.com>

-- 
Gene

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: platform/x86: thinkpad_acpi causing kernel oops commit 38b9ab80db31cf993a8f3ab2baf772083b62ca6f

[Kurt Borja]

On Mon Mar 31, 2025 at 12:05 PM -03, Genes Lists wrote:
> On Mon, 2025-03-31 at 09:24 -0300, Kurt Borja wrote:
>> 
>> I submitted a fix for this that you can test here:
>> 
>>  https://lore.kernel.org/platform-driver-x86/20250330-thinkpad-fix-v1-1-4906b3fe6b74@gmail.com/
>> 
>
> FYI - Confirm it fixes the problem here as well - tested on mainline
> commit 4e82c87058f45e79eeaa4d5bcc3b38dd3dce7209
>
>  Tested-by: Gene C <arch@sapience.com>

Thank you for testing!

Are all this driver's features present before the regression still
present after the fix?

Also would you mind re-sending your Tested-by tag to the patch thread?
This way it can get automatically picked up by maintainer tools.

-- 
 ~ Kurt

Re: platform/x86: thinkpad_acpi causing kernel oops commit 38b9ab80db31cf993a8f3ab2baf772083b62ca6f

[Genes Lists]

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]

On Mon, 2025-03-31 at 13:04 -0300, Kurt Borja wrote:
> On Mon Mar 31, 2025 at 12:05 PM -03, Genes Lists wrote:
> ...
> Are all this driver's features present before the regression still
> present after the fix?

Fixed the crash and machine seems to function normally.

> 
> Also would you mind re-sending your Tested-by tag to the patch
> thread?

Done.

thanks  for fixing !

> 

-- 
Gene

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: platform/x86: thinkpad_acpi causing kernel oops commit 38b9ab80db31cf993a8f3ab2baf772083b62ca6f

[Jeff Chua]

On Mon Mar 31, 2025 at 12:05 PM -03, Genes Lists wrote:
> On Mon, 2025-03-31 at 09:24 -0300, Kurt Borja wrote:
>>
>> I submitted a fix for this that you can test here:
>>
>>   https://lore.kernel.org/platf orm-driver-x86/20250330-thinkp ad-fix-v1-1-4906b3fe6b74@ gmail.com/
>>
> On Mon, 2025-03-31 at 13:04 -0300, Kurt Borja wrote:
> > On Mon Mar 31, 2025 at 12:05 PM -03, Genes Lists wrote:
> > ...
> > Are all this driver's features present before the regression still
> > present after the fix?
>
> Fixed the crash and machine seems to function normally.
>
> >
> > Also would you mind re-sending your Tested-by tag to the patch
> > thread?
>
> Done.
>
> thanks  for fixing !
> Gene

Tested and that fixed the crash during boot!

Thank you!

Jeff