Re: [PATCH v3] rust: regulator: add a bare minimum regulator abstraction

["Benno Lossin" <lossin@kernel.org>]

On Wed May 14, 2025 at 5:50 PM CEST, Mark Brown wrote:
> On Wed, May 14, 2025 at 05:38:40PM +0200, Benno Lossin wrote:
>> On Wed May 14, 2025 at 4:40 PM CEST, Daniel Almeida wrote:
>> > By the way, IIUC, regulator_disable() does not disable a regulator necessarily.
>> > It just tells the system that you don't care about it being enabled anymore. It can
>> > still remain on if there are other users.
>
>> Hmm, so a `struct regulator` might already be enabled and calling
>> `regulator_enable` doesn't do anything?
>
> It takes a reference to the regulator.  This may or may not result in a
> change in an underlying physical regulator.

Gotcha. So calling `regulator_enable` twice on the same regulator is
fine?

If that is the case -- and after re-reading the functions exposed on
both types `EnabledRegulator` and `Regulator` -- I am confused why we
even need two different type states? Both expose the same functions
(except `enable` and `disable`) and I don't otherwise see the purpose of
having two types.

---
Cheers,
Benno