Re: [PATCH v3] rust: regulator: add a bare minimum regulator abstraction

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 848 bytes --]

On Wed, May 14, 2025 at 06:05:11PM +0200, Benno Lossin wrote:

> Gotcha. So calling `regulator_enable` twice on the same regulator is
> fine?

Yes, absolutely.  You might potentially see this with a multi-function
device where multiple functions on the device need the same supply in
order to help reduce coordination requirements.

> If that is the case -- and after re-reading the functions exposed on
> both types `EnabledRegulator` and `Regulator` -- I am confused why we
> even need two different type states? Both expose the same functions
> (except `enable` and `disable`) and I don't otherwise see the purpose of
> having two types.

IIUC the point is to allow Rust's type system to keep track of the
reference on the regulator, otherwise the user code has to keep track of
the number of enables it's done like it currently does in C code.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]