* [PATCH] drm/msm: Fix inverted WARN_ON() logic
@ 2025-06-13 14:41 Rob Clark
2025-06-13 14:50 ` Alexey Klimov
2025-06-13 14:57 ` Alexey Klimov
0 siblings, 2 replies; 5+ messages in thread
From: Rob Clark @ 2025-06-13 14:41 UTC (permalink / raw)
To: dri-devel
Cc: freedreno, linux-arm-msm, Rob Clark, Konrad Dybcio,
Neil Armstrong, Rob Clark, Sean Paul, Konrad Dybcio,
Abhinav Kumar, Dmitry Baryshkov, Marijn Suijten, David Airlie,
Simona Vetter, open list
We want to WARN_ON() if info is NULL.
Suggested-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Fixes: 0838fc3e6718 ("drm/msm/adreno: Check for recognized GPU before bind")
Tested-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com>
---
drivers/gpu/drm/msm/adreno/adreno_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c
index 0d12454b1f2e..5c52d392427f 100644
--- a/drivers/gpu/drm/msm/adreno/adreno_device.c
+++ b/drivers/gpu/drm/msm/adreno/adreno_device.c
@@ -217,7 +217,7 @@ static int adreno_bind(struct device *dev, struct device *master, void *data)
info = adreno_info(config.chip_id);
/* We shouldn't have gotten this far if we don't recognize the GPU: */
- if (!WARN_ON(info))
+ if (WARN_ON(!info))
return -ENXIO;
config.info = info;
--
2.49.0
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/msm: Fix inverted WARN_ON() logic
2025-06-13 14:41 [PATCH] drm/msm: Fix inverted WARN_ON() logic Rob Clark
@ 2025-06-13 14:50 ` Alexey Klimov
2025-06-13 14:57 ` Alexey Klimov
1 sibling, 0 replies; 5+ messages in thread
From: Alexey Klimov @ 2025-06-13 14:50 UTC (permalink / raw)
To: Rob Clark, dri-devel
Cc: freedreno, linux-arm-msm, Konrad Dybcio, Neil Armstrong,
Rob Clark, Sean Paul, Konrad Dybcio, Abhinav Kumar,
Dmitry Baryshkov, Marijn Suijten, David Airlie, Simona Vetter,
open list
On Fri Jun 13, 2025 at 3:41 PM BST, Rob Clark wrote:
> We want to WARN_ON() if info is NULL.
>
> Suggested-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Fixes: 0838fc3e6718 ("drm/msm/adreno: Check for recognized GPU before bind")
> Tested-by: Neil Armstrong <neil.armstrong@linaro.org>
> Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com>
You forgot Reported-by tag.
Reported-by: Alexey Klimov <alexey.klimov@linaro.org>
Was the series where it is applied already merged?
[..]
Thanks,
Alexey
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/msm: Fix inverted WARN_ON() logic
2025-06-13 14:41 [PATCH] drm/msm: Fix inverted WARN_ON() logic Rob Clark
2025-06-13 14:50 ` Alexey Klimov
@ 2025-06-13 14:57 ` Alexey Klimov
2025-06-13 19:33 ` Konrad Dybcio
1 sibling, 1 reply; 5+ messages in thread
From: Alexey Klimov @ 2025-06-13 14:57 UTC (permalink / raw)
To: Rob Clark, dri-devel
Cc: freedreno, linux-arm-msm, Konrad Dybcio, Neil Armstrong,
Rob Clark, Sean Paul, Konrad Dybcio, Abhinav Kumar,
Dmitry Baryshkov, Marijn Suijten, David Airlie, Simona Vetter,
open list
On Fri Jun 13, 2025 at 3:41 PM BST, Rob Clark wrote:
> We want to WARN_ON() if info is NULL.
>
> Suggested-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Fixes: 0838fc3e6718 ("drm/msm/adreno: Check for recognized GPU before bind")
> Tested-by: Neil Armstrong <neil.armstrong@linaro.org>
> Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com>
> ---
> drivers/gpu/drm/msm/adreno/adreno_device.c | 2 +-
Apart from tag problem it is usually a good idea to add relevant people in
c/c. Especially when you fix the reported bug.
Best regards,
Alexey
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/msm: Fix inverted WARN_ON() logic
2025-06-13 14:57 ` Alexey Klimov
@ 2025-06-13 19:33 ` Konrad Dybcio
2025-06-14 15:15 ` Rob Clark
0 siblings, 1 reply; 5+ messages in thread
From: Konrad Dybcio @ 2025-06-13 19:33 UTC (permalink / raw)
To: Alexey Klimov, Rob Clark, dri-devel
Cc: freedreno, linux-arm-msm, Neil Armstrong, Rob Clark, Sean Paul,
Konrad Dybcio, Abhinav Kumar, Dmitry Baryshkov, Marijn Suijten,
David Airlie, Simona Vetter, open list
On 6/13/25 4:57 PM, Alexey Klimov wrote:
> On Fri Jun 13, 2025 at 3:41 PM BST, Rob Clark wrote:
>> We want to WARN_ON() if info is NULL.
>>
>> Suggested-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>> Fixes: 0838fc3e6718 ("drm/msm/adreno: Check for recognized GPU before bind")
>> Tested-by: Neil Armstrong <neil.armstrong@linaro.org>
>> Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com>
>> ---
>> drivers/gpu/drm/msm/adreno/adreno_device.c | 2 +-
>
> Apart from tag problem it is usually a good idea to add relevant people in
> c/c. Especially when you fix the reported bug.
with Alexey's concerns addressed:
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/msm: Fix inverted WARN_ON() logic
2025-06-13 19:33 ` Konrad Dybcio
@ 2025-06-14 15:15 ` Rob Clark
0 siblings, 0 replies; 5+ messages in thread
From: Rob Clark @ 2025-06-14 15:15 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Alexey Klimov, dri-devel, freedreno, linux-arm-msm,
Neil Armstrong, Rob Clark, Sean Paul, Konrad Dybcio,
Abhinav Kumar, Dmitry Baryshkov, Marijn Suijten, David Airlie,
Simona Vetter, open list
On Fri, Jun 13, 2025 at 12:33 PM Konrad Dybcio
<konrad.dybcio@oss.qualcomm.com> wrote:
>
> On 6/13/25 4:57 PM, Alexey Klimov wrote:
> > On Fri Jun 13, 2025 at 3:41 PM BST, Rob Clark wrote:
> >> We want to WARN_ON() if info is NULL.
> >>
> >> Suggested-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> >> Fixes: 0838fc3e6718 ("drm/msm/adreno: Check for recognized GPU before bind")
> >> Tested-by: Neil Armstrong <neil.armstrong@linaro.org>
> >> Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com>
> >> ---
> >> drivers/gpu/drm/msm/adreno/adreno_device.c | 2 +-
> >
> > Apart from tag problem it is usually a good idea to add relevant people in
> > c/c. Especially when you fix the reported bug.
>
> with Alexey's concerns addressed:
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Oops, forgot the reported-by.. but replying with the tag on list is
enough, it will be picked up when I apply the patch
BR,
-R
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-06-14 15:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-06-13 14:41 [PATCH] drm/msm: Fix inverted WARN_ON() logic Rob Clark
2025-06-13 14:50 ` Alexey Klimov
2025-06-13 14:57 ` Alexey Klimov
2025-06-13 19:33 ` Konrad Dybcio
2025-06-14 15:15 ` Rob Clark
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®