From: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
To: Andrej Picej <andrej.picej@norik.com>,
Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
Support Opensource <Support.Opensource@diasemi.com>,
"lee.jones@linaro.org" <lee.jones@linaro.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"s.riedmueller@phytec.de" <s.riedmueller@phytec.de>
Subject: RE: [PATCH 2/2] mfd: da9063: Make vbcore registers volatile
Date: Wed, 24 Nov 2021 14:47:22 +0000 [thread overview]
Message-ID: <DB9PR10MB4652377A18891B66E7449BE880619@DB9PR10MB4652.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <358de8cf-ec40-3552-da0d-98b065120649@norik.com>
On 24 November 2021 14:05, Andrej Picej wrote:
> > I don't understand the need for this change. What is this fixing? As I
> > understand it the registers in question aren't volatile so should persist.
>
> So basically this two patches were needed because we needed to enable
> internal LDOs bypass mode on the imx6 and in the process this PMICs regs
> needed to be somehow adjusted, which only worked if this regs were
> marked as volatile. Long story short, this method was only introduced in
> Phytec's version so upstreaming really doesn't make much sense.
>
> I apologize for any inconvenience, but this two patches somehow slipped
> through the process and landed on the "send-to-upstream" list. I also
> talked with @Stefan Rieadmueller and he agreed that this two patches can
> be dropped.
>
> Thanks for your time.
That's no problem and thanks for clarifying. With regmap writes, unless the
value you're writing is the same as is in the cache or is outside of the valid
range, the write should go through. Obviously something else at play in that
platform though. :)
prev parent reply other threads:[~2021-11-24 14:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 7:00 [PATCH 1/2] mfd: da9062: Make vbuck_a " Andrej Picej
2021-11-24 7:00 ` [PATCH 2/2] mfd: da9063: Make vbcore " Andrej Picej
2021-11-24 9:34 ` Adam Thomson
2021-11-24 14:04 ` Andrej Picej
2021-11-24 14:47 ` Adam Thomson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB9PR10MB4652377A18891B66E7449BE880619@DB9PR10MB4652.EURPRD10.PROD.OUTLOOK.COM \
--to=adam.thomson.opensource@diasemi.com \
--cc=Support.Opensource@diasemi.com \
--cc=andrej.picej@norik.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.riedmueller@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®