From: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
To: Andrej Picej <andrej.picej@norik.com>,
Support Opensource <Support.Opensource@diasemi.com>,
"lee.jones@linaro.org" <lee.jones@linaro.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"s.riedmueller@phytec.de" <s.riedmueller@phytec.de>
Subject: RE: [PATCH 2/2] mfd: da9063: Make vbcore registers volatile
Date: Wed, 24 Nov 2021 09:34:42 +0000 [thread overview]
Message-ID: <DB9PR10MB4652A195CDB7E237A0D87F6180619@DB9PR10MB4652.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20211124070001.2516750-2-andrej.picej@norik.com>
On 24 November 2021 07:00, Andrej Picej wrote:
> From: Stefan Riedmueller <s.riedmueller@phytec.de>
>
> The VBCORE1_A and VBCORE2_A registers are used to set the desired output
> voltage of the BCORE 1 and 2 buck regulators. These values can be critical
> if used as input for core voltages. Thus make them volatile so they do not
> get cached.
I don't understand the need for this change. What is this fixing? As I
understand it the registers in question aren't volatile so should persist.
> Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de>
> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
> ---
> drivers/mfd/da9063-i2c.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mfd/da9063-i2c.c b/drivers/mfd/da9063-i2c.c
> index 343ed6e96d87..8a3629c30382 100644
> --- a/drivers/mfd/da9063-i2c.c
> +++ b/drivers/mfd/da9063-i2c.c
> @@ -161,6 +161,7 @@ static const struct regmap_range
> da9063_ad_volatile_ranges[] = {
> regmap_reg_range(DA9063_REG_ADC_RES_L,
> DA9063_AD_REG_SECOND_D),
> regmap_reg_range(DA9063_REG_SEQ, DA9063_REG_SEQ),
> regmap_reg_range(DA9063_REG_EN_32K, DA9063_REG_EN_32K),
> + regmap_reg_range(DA9063_REG_VBCORE2_A,
> DA9063_REG_VBCORE2_A),
> regmap_reg_range(DA9063_AD_REG_MON_REG_5,
> DA9063_AD_REG_MON_REG_6),
> };
>
> @@ -206,6 +207,7 @@ static const struct regmap_range
> da9063_bb_da_volatile_ranges[] = {
> regmap_reg_range(DA9063_REG_ADC_RES_L,
> DA9063_BB_REG_SECOND_D),
> regmap_reg_range(DA9063_REG_SEQ, DA9063_REG_SEQ),
> regmap_reg_range(DA9063_REG_EN_32K, DA9063_REG_EN_32K),
> + regmap_reg_range(DA9063_REG_VBCORE2_A,
> DA9063_REG_VBCORE2_A),
> regmap_reg_range(DA9063_BB_REG_MON_REG_5,
> DA9063_BB_REG_MON_REG_6),
> };
>
> --
> 2.25.1
next prev parent reply other threads:[~2021-11-24 9:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 7:00 [PATCH 1/2] mfd: da9062: Make vbuck_a " Andrej Picej
2021-11-24 7:00 ` [PATCH 2/2] mfd: da9063: Make vbcore " Andrej Picej
2021-11-24 9:34 ` Adam Thomson [this message]
2021-11-24 14:04 ` Andrej Picej
2021-11-24 14:47 ` Adam Thomson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB9PR10MB4652A195CDB7E237A0D87F6180619@DB9PR10MB4652.EURPRD10.PROD.OUTLOOK.COM \
--to=adam.thomson.opensource@diasemi.com \
--cc=Support.Opensource@diasemi.com \
--cc=andrej.picej@norik.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=s.riedmueller@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®