Re: [PATCH 03/10] gpu: nova-core: gsp: Create wpr metadata

["Alexandre Courbot" <acourbot@nvidia.com>]

On Wed Sep 3, 2025 at 9:51 PM JST, Alexandre Courbot wrote:
>> And it's all tightly coupled anyway - for example the Gsp boot arguments require some
>> command queue offsets which are all pretty specific to the Gsp implementation.
>> Ie. we can't define some nice public API in the Gsp crate for "getting arguments
>> required for booting Gsp" without that just being "here is a struct containing
>> all the fields that must be packed into the Gsp arguments for this version",
>> which at that point may as well just be the actual struct itself right?
>
> Which particular structure are you refering to?

Ah, I guess that was about `GspArgumentsCached` and the message queue's
`get_cmdq_offsets` method. For this I guess we can just have a

    fn new(cmdq: &GspCmdq) -> Self

constructor for `GspArgumentsCached` which grabs the information it
needs from the queue and initializes itself. You would need to have this
code anyway, it's just a matter of where we put it - inside a function
of `gsp.rs`, or as a reusable (and easily replacable) constructor.