Re: [PATCH v3 0/3] arm64: dts: rockchip: introduce LinkEase EasePi R1

["Diederik de Haas" <didi.debian@cknow.org>]

[-- Attachment #1: Type: text/plain, Size: 2882 bytes --]

On Mon Sep 29, 2025 at 8:09 PM CEST, jjm2473 wrote:
> I have another question. If there are reviewers or co-authors later,
> do I need to add it to the commit message and send it again?
> Or should the reviewer or co-author add the message and
> continue to deliver the patch?

When you get a Reviewed-by tag, you should add that tag too to a new
version. But there's no need to send a new version to just add those
tags, the tooling used by maintainers picks those up themselves.

If you 'just' get review comments, then you'd usually just
improve the patch and you could reference it in a changelog item (to
indicate you addressed it, ttboyk).
If you think a reviewer helped you 'significantly', you could choose to
add an Helped-by tag, but whether you think someone deserves some
credits that way, is up to you(r judgement).

(Co-)authors are usually known upon first submission. If you later find
out that that list was incorrect/incomplete, then you would add
Co-developed-by + Signed-off-by tags on a new version.

HTH,
  Diederik

> Diederik de Haas <didi.debian@cknow.org> 于2025年9月29日周一 18:20写道：
>>
>> On Mon Sep 29, 2025 at 8:57 AM CEST, Liangbin Lian wrote:
>> > LinkEase EasePi R1 [1] is a high-performance mini router.
>> > ...
>> > [1] https://doc.linkease.com/zh/guide/easepi-r1/hardware.html
>> >
>> > Signed-off-by: Liangbin Lian <jjm2473@gmail.com>
>> > ---
>> >
>> > Changes in v2:
>> > - Change deprecated "rockchip,system-power-controller" to "system-power-controller"
>> > - Link to v1: https://lore.kernel.org/r/20250925055906.83375-1-jjm2473@gmail.com/
>>
>> You received an Acked-by on patch 1 and 2 in v1 of this patch set.
>> You're supposed to add that to the next/new version(s) or explain why
>> you choose not to do that (bc f.e. there was a major change, but that
>> does not seem applicable to those patches).
>>
>> Cheers,
>>   Diederik
>>
>> > Changes in v3:
>> > - Fix typo ('status = "disable"' -> 'status = "disabled"') found by kernel test robot https://lore.kernel.org/all/202509261328.Grjhp029-lkp@intel.com/
>> > - Link to v2: https://lore.kernel.org/r/20250925092037.13582-1-jjm2473@gmail.com/
>> >
>> > ---
>> >
>> > Liangbin Lian (3):
>> >   dt-bindings: vendor-prefixes: Document LinkEase
>> >   dt-bindings: arm: rockchip: Add LinkEase EasePi R1
>> >   arm64: dts: rockchip: add LinkEase EasePi R1
>> >
>> >  .../devicetree/bindings/arm/rockchip.yaml     |   5 +
>> >  .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
>> >  arch/arm64/boot/dts/rockchip/Makefile         |   1 +
>> >  .../boot/dts/rockchip/rk3568-easepi-r1.dts    | 692 ++++++++++++++++++
>> >  4 files changed, 700 insertions(+)
>> >  create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-easepi-r1.dts
>> >
>> >
>> > base-commit: d0ca0df179c4b21e2a6c4a4fb637aa8fa14575cb
>>


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]