From: Andrew Lunn <andrew@lunn.ch>
To: Liangbin Lian <jjm2473@gmail.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
heiko@sntech.de, quentin.schulz@cherry.de,
kever.yang@rock-chips.com, naoki@radxa.com,
honyuenkwun@gmail.com, inindev@gmail.com,
ivan8215145640@gmail.com, neil.armstrong@linaro.org,
mani@kernel.org, dsimic@manjaro.org, pbrobinson@gmail.com,
alchark@gmail.com, didi.debian@cknow.org, jbx6244@gmail.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] arm64: dts: rockchip: add LinkEase EasePi R1
Date: Mon, 6 Oct 2025 17:51:15 +0200 [thread overview]
Message-ID: <d8ad476c-d0c7-4e97-9e76-540a539ffb52@lunn.ch> (raw)
In-Reply-To: <20250929065714.27741-4-jjm2473@gmail.com>
> +&gmac0 {
> + phy-mode = "rgmii";
Did i really miss this patch series in its earlier version, or did you
ignore me?
https://elixir.bootlin.com/linux/v6.15/source/Documentation/devicetree/bindings/net/ethernet-controller.yaml#L287
> + tx_delay = <0x3c>;
> + rx_delay = <0x2f>;
Please change it to rgmii-id, and smaller tx/rx_delay values. Or show
us the schematics which clearly show extra long clock lines.
> +/* Micro SD card slot is not mounted */
> +&sdmmc0 {
> + max-frequency = <150000000>;
> + no-sdio;
> + no-mmc;
> + bus-width = <4>;
> + cap-mmc-highspeed;
> + cap-sd-highspeed;
> + disable-wp;
> + pinctrl-names = "default";
> + pinctrl-0 = <&sdmmc0_bus4 &sdmmc0_clk &sdmmc0_cmd &sdmmc0_det>;
> + vmmc-supply = <&vcc3v3_sd>;
> + vqmmc-supply = <&vccio_sd>;
> + status = "disabled";
> +};
> +
> +/* Wifi module is not mounted */
> +&sdmmc2 {
What do you mean by "not mounted"?
Often you would say "not populated", to indicate the PCB has all the
tracks in place, but the chip has simply not been soldered in place.
Or is there a connector here, and nothing plugged into the connector?
Andrew
next prev parent reply other threads:[~2025-10-06 15:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-29 6:57 [PATCH v3 0/3] arm64: dts: rockchip: introduce " Liangbin Lian
2025-09-29 6:57 ` [PATCH v3 1/3] dt-bindings: vendor-prefixes: Document LinkEase Liangbin Lian
2025-09-29 12:27 ` Heiko Stuebner
2025-09-29 6:57 ` [PATCH v3 2/3] dt-bindings: arm: rockchip: Add LinkEase EasePi R1 Liangbin Lian
2025-09-29 12:28 ` Heiko Stuebner
2025-09-29 18:20 ` jjm2473
2025-10-06 15:43 ` Andrew Lunn
2025-10-07 14:56 ` jjm2473
2025-09-29 6:57 ` [PATCH v3 3/3] arm64: dts: rockchip: add " Liangbin Lian
2025-10-06 15:51 ` Andrew Lunn [this message]
2025-10-07 14:32 ` jjm2473
2025-10-07 14:57 ` Andrew Lunn
2025-10-07 16:25 ` Russell King (Oracle)
2025-10-07 16:32 ` Quentin Schulz
2025-10-07 17:29 ` jjm2473
2025-10-07 18:32 ` Andrew Lunn
2025-10-09 8:47 ` Alexey Charkov
2025-10-09 13:04 ` Andrew Lunn
2025-10-07 18:48 ` Russell King (Oracle)
2025-10-09 5:16 ` jjm2473
2025-09-29 10:20 ` [PATCH v3 0/3] arm64: dts: rockchip: introduce " Diederik de Haas
2025-09-29 18:09 ` jjm2473
2025-09-30 11:19 ` Diederik de Haas
2025-09-30 17:52 ` jjm2473
2025-10-07 16:27 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8ad476c-d0c7-4e97-9e76-540a539ffb52@lunn.ch \
--to=andrew@lunn.ch \
--cc=alchark@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=didi.debian@cknow.org \
--cc=dsimic@manjaro.org \
--cc=heiko@sntech.de \
--cc=honyuenkwun@gmail.com \
--cc=inindev@gmail.com \
--cc=ivan8215145640@gmail.com \
--cc=jbx6244@gmail.com \
--cc=jjm2473@gmail.com \
--cc=kever.yang@rock-chips.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mani@kernel.org \
--cc=naoki@radxa.com \
--cc=neil.armstrong@linaro.org \
--cc=pbrobinson@gmail.com \
--cc=quentin.schulz@cherry.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®