From: "Luca Ceresoli" <luca.ceresoli@bootlin.com>
To: "Daniel Thompson" <danielt@kernel.org>,
"Sverdlin, Alexander" <alexander.sverdlin@siemens.com>
Cc: "jingoohan1@gmail.com" <jingoohan1@gmail.com>,
"tomi.valkeinen@ti.com" <tomi.valkeinen@ti.com>,
"lee@kernel.org" <lee@kernel.org>,
"tony@atomide.com" <tony@atomide.com>,
"pavel@ucw.cz" <pavel@ucw.cz>, "deller@gmx.de" <deller@gmx.de>,
"jjhiblot@ti.com" <jjhiblot@ti.com>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
"thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>,
"saravanak@google.com" <saravanak@google.com>,
"herve.codina@bootlin.com" <herve.codina@bootlin.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"alexander.sverdlin@gmail.com" <alexander.sverdlin@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"daniel.thompson@linaro.org" <daniel.thompson@linaro.org>
Subject: Re: [PATCH v6] backlight: led-backlight: add devlink to supplier LEDs
Date: Thu, 30 Oct 2025 13:54:29 +0100 [thread overview]
Message-ID: <DDVO7L4Q3GC0.1B3RH5DEQ20HV@bootlin.com> (raw)
In-Reply-To: <aQJSqJOrtETMKt8x@aspen.lan>
Hello,
On Wed Oct 29, 2025 at 6:45 PM CET, Daniel Thompson wrote:
> On Thu, Oct 23, 2025 at 12:41:30PM +0000, Sverdlin, Alexander wrote:
>> Hi Lee, Daniel, Jingoo,
>>
>> On Mon, 2025-05-19 at 22:19 +0200, Luca Ceresoli wrote:
>> > led-backlight is a consumer of one or multiple LED class devices, but
>> > devlink is currently unable to create correct supplier-producer links when
>> > the supplier is a class device. It creates instead a link where the
>> > supplier is the parent of the expected device.
>> > <snip>
>> > Fixes: ae232e45acf9 ("backlight: add led-backlight driver")
>> > Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
>> > Reviewed-by: Herve Codina <herve.codina@bootlin.com>
>>
>> I've noticed that the patch in archived in the patchwork [1] but I wasn't
>> able to find it in any branch of the backlight tree [2].
>>
>> Could it be that the patch somehow slipped through?
>> It does solve a real-world crash, could you please consider to apply it?
>
> Sorry folks. I overlooked this in my backlog and never posted the R-b
> (which helps Lee figure out what to hoover up).
>
> Reviewed-by: Daniel Thompson (RISCstar) <danielt@kernel.org>
Thanks Alexander for pinging and Daniel for reviewing!
I double checked right now and can confirm:
* the bug is still present on v6.18-rc3
* the patch applies cleanly on v6.18-rc3
* the patch is still fixing the bug
Best regards,
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2025-10-30 12:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-19 20:19 Luca Ceresoli
2025-05-20 6:05 ` Herve Codina
2025-10-23 12:41 ` Sverdlin, Alexander
2025-10-29 17:45 ` Daniel Thompson
2025-10-30 12:54 ` Luca Ceresoli [this message]
2025-11-06 17:00 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DDVO7L4Q3GC0.1B3RH5DEQ20HV@bootlin.com \
--to=luca.ceresoli@bootlin.com \
--cc=alexander.sverdlin@gmail.com \
--cc=alexander.sverdlin@siemens.com \
--cc=daniel.thompson@linaro.org \
--cc=danielt@kernel.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=herve.codina@bootlin.com \
--cc=jingoohan1@gmail.com \
--cc=jjhiblot@ti.com \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=saravanak@google.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®