From: Ed Cashin <ecashin@coraid.com>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: "yongjun_wei@trendmicro.com.cn" <yongjun_wei@trendmicro.com.cn>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] aoe: remove unused variable in resend()
Date: Mon, 22 Oct 2012 14:56:32 -0500 [thread overview]
Message-ID: <DFBFBFD3-4B29-4233-B109-C6AFFB57BBF2@coraid.com> (raw)
In-Reply-To: <CAPgLHd9yWbukGH_mNJo0fRmG7q8RctQghPQo8wxBn_n8hzn=zQ@mail.gmail.com>
Looks good, thanks.
On Oct 22, 2012, at 5:17 AM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> The variable ah is initialized but never used
> otherwise, so remove the unused variable.
>
> dpatch engine is used to auto generate this patch.
> (https://github.com/weiyj/dpatch)
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/block/aoe/aoecmd.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c
> index 3804a0a..812eb8a 100644
> --- a/drivers/block/aoe/aoecmd.c
> +++ b/drivers/block/aoe/aoecmd.c
> @@ -425,7 +425,6 @@ resend(struct aoedev *d, struct frame *f)
> struct sk_buff *skb;
> struct sk_buff_head queue;
> struct aoe_hdr *h;
> - struct aoe_atahdr *ah;
> struct aoetgt *t;
> char buf[128];
> u32 n;
> @@ -440,7 +439,6 @@ resend(struct aoedev *d, struct frame *f)
> return;
> }
> h = (struct aoe_hdr *) skb_mac_header(skb);
> - ah = (struct aoe_atahdr *) (h+1);
>
> snprintf(buf, sizeof buf,
> "%15s e%ld.%d oldtag=%08x@%08lx newtag=%08x s=%pm d=%pm nout=%d\n",
>
--
Ed Cashin
ecashin@coraid.com
next prev parent reply other threads:[~2012-10-22 19:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 9:17 Wei Yongjun
2012-10-22 19:56 ` Ed Cashin [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-10-22 9:13 Wei Yongjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFBFBFD3-4B29-4233-B109-C6AFFB57BBF2@coraid.com \
--to=ecashin@coraid.com \
--cc=linux-kernel@vger.kernel.org \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®