mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] aoe: remove unused variable in resend()
@ 2012-10-22  9:17 Wei Yongjun
  2012-10-22 19:56 ` Ed Cashin
  0 siblings, 1 reply; 3+ messages in thread
From: Wei Yongjun @ 2012-10-22  9:17 UTC (permalink / raw)
  To: ecashin; +Cc: yongjun_wei, linux-kernel

From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

The variable ah is initialized but never used
otherwise, so remove the unused variable.

dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
 drivers/block/aoe/aoecmd.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c
index 3804a0a..812eb8a 100644
--- a/drivers/block/aoe/aoecmd.c
+++ b/drivers/block/aoe/aoecmd.c
@@ -425,7 +425,6 @@ resend(struct aoedev *d, struct frame *f)
 	struct sk_buff *skb;
 	struct sk_buff_head queue;
 	struct aoe_hdr *h;
-	struct aoe_atahdr *ah;
 	struct aoetgt *t;
 	char buf[128];
 	u32 n;
@@ -440,7 +439,6 @@ resend(struct aoedev *d, struct frame *f)
 		return;
 	}
 	h = (struct aoe_hdr *) skb_mac_header(skb);
-	ah = (struct aoe_atahdr *) (h+1);
 
 	snprintf(buf, sizeof buf,
 		"%15s e%ld.%d oldtag=%08x@%08lx newtag=%08x s=%pm d=%pm nout=%d\n",


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] aoe: remove unused variable in resend()
  2012-10-22  9:17 [PATCH] aoe: remove unused variable in resend() Wei Yongjun
@ 2012-10-22 19:56 ` Ed Cashin
  0 siblings, 0 replies; 3+ messages in thread
From: Ed Cashin @ 2012-10-22 19:56 UTC (permalink / raw)
  To: Wei Yongjun; +Cc: yongjun_wei, linux-kernel

Looks good, thanks.

On Oct 22, 2012, at 5:17 AM, Wei Yongjun wrote:

> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> The variable ah is initialized but never used
> otherwise, so remove the unused variable.
> 
> dpatch engine is used to auto generate this patch.
> (https://github.com/weiyj/dpatch)
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/block/aoe/aoecmd.c | 2 --
> 1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c
> index 3804a0a..812eb8a 100644
> --- a/drivers/block/aoe/aoecmd.c
> +++ b/drivers/block/aoe/aoecmd.c
> @@ -425,7 +425,6 @@ resend(struct aoedev *d, struct frame *f)
> 	struct sk_buff *skb;
> 	struct sk_buff_head queue;
> 	struct aoe_hdr *h;
> -	struct aoe_atahdr *ah;
> 	struct aoetgt *t;
> 	char buf[128];
> 	u32 n;
> @@ -440,7 +439,6 @@ resend(struct aoedev *d, struct frame *f)
> 		return;
> 	}
> 	h = (struct aoe_hdr *) skb_mac_header(skb);
> -	ah = (struct aoe_atahdr *) (h+1);
> 
> 	snprintf(buf, sizeof buf,
> 		"%15s e%ld.%d oldtag=%08x@%08lx newtag=%08x s=%pm d=%pm nout=%d\n",
> 

-- 
  Ed Cashin
  ecashin@coraid.com



^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] aoe: remove unused variable in resend()
@ 2012-10-22  9:13 Wei Yongjun
  0 siblings, 0 replies; 3+ messages in thread
From: Wei Yongjun @ 2012-10-22  9:13 UTC (permalink / raw)
  To: ecashin; +Cc: yongjun_wei, linux-kernel

From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

The variable ah is initialized but never used
otherwise, so remove the unused variable.

dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
 drivers/block/aoe/aoecmd.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c
index 3804a0a..812eb8a 100644
--- a/drivers/block/aoe/aoecmd.c
+++ b/drivers/block/aoe/aoecmd.c
@@ -425,7 +425,6 @@ resend(struct aoedev *d, struct frame *f)
 	struct sk_buff *skb;
 	struct sk_buff_head queue;
 	struct aoe_hdr *h;
-	struct aoe_atahdr *ah;
 	struct aoetgt *t;
 	char buf[128];
 	u32 n;
@@ -440,7 +439,6 @@ resend(struct aoedev *d, struct frame *f)
 		return;
 	}
 	h = (struct aoe_hdr *) skb_mac_header(skb);
-	ah = (struct aoe_atahdr *) (h+1);
 
 	snprintf(buf, sizeof buf,
 		"%15s e%ld.%d oldtag=%08x@%08lx newtag=%08x s=%pm d=%pm nout=%d\n",


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-10-22 19:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-22  9:17 [PATCH] aoe: remove unused variable in resend() Wei Yongjun
2012-10-22 19:56 ` Ed Cashin
  -- strict thread matches above, loose matches on Subject: below --
2012-10-22  9:13 Wei Yongjun

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®