Re: [PATCH 4/6] drm/mcde: dsi: convert to of_drm_find_and_get_bridge()

["Luca Ceresoli" <luca.ceresoli@bootlin.com>]

Hello Linus,

On Mon Jan 19, 2026 at 9:57 AM CET, Linus Walleij wrote:
> On Fri, Jan 16, 2026 at 6:33 PM Luca Ceresoli <luca.ceresoli@bootlin.com> wrote:
>
>> of_drm_find_bridge() is deprecated. Move to its replacement
>> of_drm_find_and_get_bridge() which gets a bridge reference, and ensure it
>> is put when done.
>>
>> We need to handle the two cases: when a panel is found and when it isn't,
>> even though the latter is not supported. So:
>>
>>  * in case a panel is not found and bridge is, get a reference to the
>>    found bridge
>>  * in case a panel is found, get a reference to the panel_bridge when it
>>    is added, so the following code always get exactly one reference that
>>    it needs to put
>>
>> Finally, use the next_bridge pointer in struct drm_bridge in order to
>> simplify putting the reference.
>>
>> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
>
> I do not understand the change as a whole but the approach
> looks sane so:
> Acked-by: Linus Walleij <linusw@kernel.org>

Thanks!

However I'm not adding your A-by to v2. The change you suggested to patch 3
(break instead of warn) made the drm_bridge_put() call in this patch
unnecessary, so I dropped it for v2, making this patch slightly different.

I hope you'll Ack v2 too. :)

Luca

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com