* [PATCH] drm/imx: parallel-display: check return value of devm_drm_bridge_add() in imx_pd_probe()
@ 2026-02-04 9:06 Chen Ni
2026-02-05 9:15 ` Luca Ceresoli
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chen Ni @ 2026-02-04 9:06 UTC (permalink / raw)
To: p.zabel, maarten.lankhorst, mripard, tzimmermann, airlied,
simona, Frank.Li, s.hauer, kernel, festevam, luca.ceresoli,
louis.chauvet
Cc: dri-devel, imx, linux-arm-kernel, linux-kernel, Chen Ni
Return the value of devm_drm_bridge_add() in order to propagate the
error properly, if it fails due to resource allocation failure or bridge
registration failure.
This ensures that the probe function fails safely rather than proceeding
with a potentially incomplete bridge setup.
Fixes: bf7e97910b9f ("drm/imx: parallel-display: add the bridge before attaching it")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
drivers/gpu/drm/imx/ipuv3/parallel-display.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/imx/ipuv3/parallel-display.c b/drivers/gpu/drm/imx/ipuv3/parallel-display.c
index 6fbf505d2801..590120a33fa0 100644
--- a/drivers/gpu/drm/imx/ipuv3/parallel-display.c
+++ b/drivers/gpu/drm/imx/ipuv3/parallel-display.c
@@ -256,7 +256,9 @@ static int imx_pd_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, imxpd);
- devm_drm_bridge_add(dev, &imxpd->bridge);
+ ret = devm_drm_bridge_add(dev, &imxpd->bridge);
+ if (ret)
+ return ret;
return component_add(dev, &imx_pd_ops);
}
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/imx: parallel-display: check return value of devm_drm_bridge_add() in imx_pd_probe()
2026-02-04 9:06 [PATCH] drm/imx: parallel-display: check return value of devm_drm_bridge_add() in imx_pd_probe() Chen Ni
@ 2026-02-05 9:15 ` Luca Ceresoli
2026-02-05 13:04 ` Markus Elfring
2026-02-20 12:44 ` Luca Ceresoli
2 siblings, 0 replies; 4+ messages in thread
From: Luca Ceresoli @ 2026-02-05 9:15 UTC (permalink / raw)
To: Chen Ni, p.zabel, maarten.lankhorst, mripard, tzimmermann,
airlied, simona, Frank.Li, s.hauer, kernel, festevam,
louis.chauvet
Cc: dri-devel, imx, linux-arm-kernel, linux-kernel
On Wed Feb 4, 2026 at 10:06 AM CET, Chen Ni wrote:
> Return the value of devm_drm_bridge_add() in order to propagate the
> error properly, if it fails due to resource allocation failure or bridge
> registration failure.
>
> This ensures that the probe function fails safely rather than proceeding
> with a potentially incomplete bridge setup.
>
> Fixes: bf7e97910b9f ("drm/imx: parallel-display: add the bridge before attaching it")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/imx: parallel-display: check return value of devm_drm_bridge_add() in imx_pd_probe()
2026-02-04 9:06 [PATCH] drm/imx: parallel-display: check return value of devm_drm_bridge_add() in imx_pd_probe() Chen Ni
2026-02-05 9:15 ` Luca Ceresoli
@ 2026-02-05 13:04 ` Markus Elfring
2026-02-20 12:44 ` Luca Ceresoli
2 siblings, 0 replies; 4+ messages in thread
From: Markus Elfring @ 2026-02-05 13:04 UTC (permalink / raw)
To: Chen Ni, imx, dri-devel, kernel, linux-arm-kernel, David Airlie,
Fabio Estevam, Frank Li, Louis Chauvet, Luca Ceresoli,
Maarten Lankhorst, Maxime Ripard, Philipp Zabel, Sascha Hauer,
Simona Vetter, Thomas Zimmermann
Cc: LKML
> Return the value of devm_drm_bridge_add() in order to propagate the
> error properly, if it fails due to resource allocation failure or bridge
> registration failure.
…
* Were any source code analysis tools involved here?
* See also once more:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/stable-kernel-rules.rst?h=v6.19-rc8#n34
Regards,
Markus
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/imx: parallel-display: check return value of devm_drm_bridge_add() in imx_pd_probe()
2026-02-04 9:06 [PATCH] drm/imx: parallel-display: check return value of devm_drm_bridge_add() in imx_pd_probe() Chen Ni
2026-02-05 9:15 ` Luca Ceresoli
2026-02-05 13:04 ` Markus Elfring
@ 2026-02-20 12:44 ` Luca Ceresoli
2 siblings, 0 replies; 4+ messages in thread
From: Luca Ceresoli @ 2026-02-20 12:44 UTC (permalink / raw)
To: p.zabel, maarten.lankhorst, mripard, tzimmermann, airlied,
simona, Frank.Li, s.hauer, kernel, festevam, louis.chauvet,
Chen Ni
Cc: dri-devel, imx, linux-arm-kernel, linux-kernel
On Wed, 04 Feb 2026 17:06:29 +0800, Chen Ni wrote:
> Return the value of devm_drm_bridge_add() in order to propagate the
> error properly, if it fails due to resource allocation failure or bridge
> registration failure.
>
> This ensures that the probe function fails safely rather than proceeding
> with a potentially incomplete bridge setup.
>
> [...]
Applied, thanks!
[1/1] drm/imx: parallel-display: check return value of devm_drm_bridge_add() in imx_pd_probe()
commit: c5f8658f97ec392eeaf355d4e9775ae1f23ca1d3
Best regards,
--
Luca Ceresoli <luca.ceresoli@bootlin.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-02-20 12:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-04 9:06 [PATCH] drm/imx: parallel-display: check return value of devm_drm_bridge_add() in imx_pd_probe() Chen Ni
2026-02-05 9:15 ` Luca Ceresoli
2026-02-05 13:04 ` Markus Elfring
2026-02-20 12:44 ` Luca Ceresoli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®