Re: [PATCH v2] drm/bridge: synopsys: dw-dp: Check return value of devm_drm_bridge_add() in dw_dp_bind()

["Luca Ceresoli" <luca.ceresoli@bootlin.com>]

On Thu Feb 5, 2026 at 10:06 AM CET, Luca Ceresoli wrote:
>> --- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c
>> +++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
>> @@ -2049,7 +2049,11 @@ struct dw_dp *dw_dp_bind(struct device *dev, struct drm_encoder *encoder,
>>  	bridge->type = DRM_MODE_CONNECTOR_DisplayPort;
>>  	bridge->ycbcr_420_allowed = true;
>>
>> -	devm_drm_bridge_add(dev, bridge);
>> +	ret = devm_drm_bridge_add(dev, bridge);
>> +	if (ret) {
>> +		dev_err_probe(dev, ret, "failed to add bridge\n");
>> +		return ERR_PTR(ret);
>> +	}
>
> Looks correct, but can be simpler:
>
> 	ret = devm_drm_bridge_add(dev, bridge);
> 	if (ret)
> 		return ERR_PTR(dev_err_probe(dev, ret, "failed to add bridge\n"));

I noticed you are doing the same fix in [0] but without logging a
message. Either is fine, but I don't see why using a different policy. I
think not logging anything for devm_drm_bridge_add() is fine, because the
only error it can return is on a small memory allocation which de facto
cannot happen. So I'm OK if you just ditch the message in v3.

[0] https://lore.kernel.org/lkml/20260204090629.2209542-1-nichen@iscas.ac.cn/

Luca

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com