mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "Giorgi Tchankvetadze" <giorgitchankvetadze1997@gmail.com>,
	<gregkh@linuxfoundation.org>, <linux-staging@lists.linux.dev>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: rtl8723bs: remove redundant NULL check on premainder_ie
Date: Sat, 21 Feb 2026 12:44:58 -0600	[thread overview]
Message-ID: <DGKV21DET5W6.2OFCJE8T8XJEL@gmail.com> (raw)
In-Reply-To: <20260221124732.327156-2-giorgitchankvetadze1997@gmail.com>

On Sat Feb 21, 2026 at 6:47 AM CST, Giorgi Tchankvetadze wrote:
> premainder_ie is computed as pwps_ie + wps_ielen, where pwps_ie is
> already validated non-NULL earlier in the function. Pointer arithmetic
> on a non-NULL pointer can never yield NULL, making this check always
> true and misleading. Replace with a simple check on remainder_ielen.
>
> Signed-off-by: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
> ---

LGTM.

Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>

Thanks,

ET

      reply	other threads:[~2026-02-21 18:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-21 12:47 Giorgi Tchankvetadze
2026-02-21 18:44 ` Ethan Tidmore [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DGKV21DET5W6.2OFCJE8T8XJEL@gmail.com \
    --to=ethantidmore06@gmail.com \
    --cc=giorgitchankvetadze1997@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®