From: "Folker Schwesinger" <dev@folker-schwesinger.de>
To: "Rahul Navale" <rahulnavale04@gmail.com>
Cc: "Rahul Navale" <rahul.navale@ifm.com>,
<dmaengine@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <vkoul@kernel.org>,
<Frank.Li@kernel.org>, <michal.simek@amd.com>,
<suraj.gupta2@amd.com>, <thomas.gessler@brueckmann-gmbh.de>,
<radhey.shyam.pandey@amd.com>, <tomi.valkeinen@ideasonboard.com>,
<marex@nabladev.com>, <marex@denx.de>
Subject: Re: [RFC PATCH] dmaengine: xilinx_dma: Fix per-channel direction reporting via device_caps
Date: Tue, 03 Mar 2026 20:19:35 +0000 [thread overview]
Message-ID: <DGTFBXGJDU7C.3KAUWCSCGQFR2@folker-schwesinger.de> (raw)
In-Reply-To: <DGTF4AVSQZBJ.184UEIYAHWGMW@folker-schwesinger.de>
On Tue Mar 3, 2026 at 9:09 PM CET, Folker Schwesinger wrote:
> So I think it's reasonable to assume that either (1) the change in
> return value of dma_get_slave_caps() causes different behaviour in the
> callers (possibly [2][3]; needs verification) or that (2) dma_slave_caps
> *caps, whose fields now get populated in dma_get_slave_caps() cause
> different behavior in downstream users of said caps.
>
> For the next debugging step I suggest that we focus on (2) but also on
> getting some insight into the callers. Could you please reapply
> 7e01511443c3, keep the RFC patch in place...
To quickly test theory (2), you could then comment out the caps->
assignments in dma_get_slave_caps() and check if this fixes your issue
or not.
<-->8-->
diff --git i/drivers/dma/dmaengine.c w/drivers/dma/dmaengine.c
index ca13cd39330b..91c5d7abb028 100644
--- i/drivers/dma/dmaengine.c
+++ w/drivers/dma/dmaengine.c
@@ -592,6 +592,7 @@ int dma_get_slave_caps(struct dma_chan *chan, struct dma_slave_caps *caps)
if (!device->directions)
return -ENXIO;
+ /*
caps->src_addr_widths = device->src_addr_widths;
caps->dst_addr_widths = device->dst_addr_widths;
caps->directions = device->directions;
@@ -603,6 +604,7 @@ int dma_get_slave_caps(struct dma_chan *chan, struct dma_slave_caps *caps)
caps->cmd_pause = !!device->device_pause;
caps->cmd_resume = !!device->device_resume;
caps->cmd_terminate = !!device->device_terminate_all;
+ */
/*
* DMA engine device might be configured with non-uniformly
<--8<-->
next prev parent reply other threads:[~2026-03-03 20:19 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-17 18:49 Folker Schwesinger
2026-02-20 9:14 ` Rahul Navale
2026-02-20 9:30 ` Pandey, Radhey Shyam
2026-02-20 13:28 ` Rahul Navale
2026-02-20 19:09 ` Folker Schwesinger
2026-02-24 9:30 ` Rahul Navale
2026-02-24 15:10 ` Folker Schwesinger
2026-02-26 7:35 ` Rahul Navale
2026-02-26 20:06 ` Folker Schwesinger
2026-02-26 8:02 ` Rahul Navale
2026-03-02 7:24 ` Rahul Navale
2026-03-03 20:09 ` Folker Schwesinger
2026-03-03 20:19 ` Folker Schwesinger [this message]
2026-03-04 8:35 ` Rahul Navale
2026-03-04 14:49 ` Folker Schwesinger
2026-03-05 7:23 ` Rahul Navale
2026-03-05 8:22 ` Folker Schwesinger
2026-03-05 8:29 ` Rahul Navale
2026-03-05 8:32 ` Folker Schwesinger
2026-03-05 11:27 ` Rahul Navale
2026-03-06 10:38 ` Folker Schwesinger
2026-03-09 7:28 ` Rahul Navale
2026-03-14 8:35 ` Folker Schwesinger
2026-03-16 22:35 ` Marek Vasut
2026-03-14 8:45 ` Folker Schwesinger
2026-03-17 10:49 ` Rahul Navale
2026-03-17 17:20 ` Marek Vasut
2026-03-18 12:35 ` Rahul Navale
2026-03-27 14:51 ` Marek Vasut
2026-03-25 14:22 ` Rahul Navale
2026-03-27 11:43 ` Michal Simek
2026-03-30 12:21 ` Rahul Navale
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGTFBXGJDU7C.3KAUWCSCGQFR2@folker-schwesinger.de \
--to=dev@folker-schwesinger.de \
--cc=Frank.Li@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=marex@nabladev.com \
--cc=michal.simek@amd.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=rahul.navale@ifm.com \
--cc=rahulnavale04@gmail.com \
--cc=suraj.gupta2@amd.com \
--cc=thomas.gessler@brueckmann-gmbh.de \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome