From: Brendan Jackman <jackmanb@google.com>
To: Dave Hansen <dave.hansen@intel.com>,
Brendan Jackman <jackmanb@google.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>, <x86@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: fix location of comment about pgd_list
Date: Wed, 11 Mar 2026 17:13:22 +0000 [thread overview]
Message-ID: <DH04DPSYQRPW.13761NUC4IRVQ@google.com> (raw)
In-Reply-To: <04be68a0-86c8-466c-b6b7-de55074c1989@intel.com>
On Wed Mar 11, 2026 at 4:39 PM UTC, Dave Hansen wrote:
> On 3/11/26 07:04, Brendan Jackman wrote:
>> This venerable comment got detached from its context when the code moved
>> in commit 394158559d4c ("x86: move all the pgd_list handling to one
>> place"). Put it back next to that code.
>
> Shouldn't the comment about the data structure be on the *data*
> *structure*, not the code?
>
> LIST_HEAD(pgd_list);
>
> ?
Yep, you're right.
>
> But either way, I think the comment should just be chopped down to
> something much smaller, maybe:
>
> /*
> * A list of all PGD pages. Mainly used to keep shared kernel
> * mapping page tables in sync. Needed because PGDs are private
> * to each process.
> */
Great, sounds good to me. I'll let this sit a little in case anyone has
other additions/corrections then post a v2.
prev parent reply other threads:[~2026-03-11 17:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 14:04 Brendan Jackman
2026-03-11 16:39 ` Dave Hansen
2026-03-11 17:13 ` Brendan Jackman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DH04DPSYQRPW.13761NUC4IRVQ@google.com \
--to=jackmanb@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®