mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Luca Weiss" <luca.weiss@fairphone.com>
To: "Konrad Dybcio" <konradybcio@kernel.org>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Tengfei Fan" <tengfei.fan@oss.qualcomm.com>,
	"Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com>,
	"Jingyi Wang" <jingyi.wang@oss.qualcomm.com>,
	"Luca Weiss" <luca.weiss@fairphone.com>,
	"Vinod Koul" <vkoul@kernel.org>,
	"Dmitry Baryshkov" <lumag@kernel.org>,
	"Sai Prakash Ranjan" <quic_saipraka@quicinc.com>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Abel Vesa" <abelvesa@kernel.org>,
	"Raviteja Laggyshetty" <quic_rlaggysh@quicinc.com>,
	"Melody Olvera" <quic_molvera@quicinc.com>,
	"Taniya Das" <quic_tdas@quicinc.com>
Cc: <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	"Jishnu Prakash" <quic_jprakash@quicinc.com>,
	"Konrad Dybcio" <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH 2/6] arm64: dts: qcom: milos: Fix GIC_ITS range length
Date: Tue, 17 Mar 2026 15:50:07 +0100	[thread overview]
Message-ID: <DH553B1YAFG5.1UT90QXHUSGM1@fairphone.com> (raw)
In-Reply-To: <20260317-topic-its_range_fixup-v1-2-49be8076adb1@oss.qualcomm.com>

On Tue Mar 17, 2026 at 3:41 PM CET, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>
> Currently, the GITS_SGIR register is cut off. Fix it up.
>
> Fixes: d9d59d105f98 ("arm64: dts: qcom: Add initial Milos dtsi")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/milos.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/milos.dtsi b/arch/arm64/boot/dts/qcom/milos.dtsi
> index e1a51d43943f..084be5316e0d 100644
> --- a/arch/arm64/boot/dts/qcom/milos.dtsi
> +++ b/arch/arm64/boot/dts/qcom/milos.dtsi
> @@ -1911,7 +1911,7 @@ ppi_cluster1: interrupt-partition-1 {
>  
>  			gic_its: msi-controller@17140000 {
>  				compatible = "arm,gic-v3-its";
> -				reg = <0x0 0x17140000 0x0 0x20000>;
> +				reg = <0x0 0x17140000 0x0 0x40000>;

The .FLAT doesn't make it super obvious what the size should be, but
yes, GITS0_SGIR would be outside the range with 0x20000, and 0x40000
looks sane given at 0x1718_0000 the next register after GITS0_SGIR is
located.

Reviewed-by: Luca Weiss <luca.weiss@fairphone.com>


>  
>  				msi-controller;
>  				#msi-cells = <1>;


  reply	other threads:[~2026-03-17 14:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-17 14:41 [PATCH 0/6] Fix up GIC_ITS ranges in QCOM DTs Konrad Dybcio
2026-03-17 14:41 ` [PATCH 1/6] arm64: dts: qcom: kaanapali: Fix GIC_ITS range length Konrad Dybcio
2026-03-17 14:41 ` [PATCH 2/6] arm64: dts: qcom: milos: " Konrad Dybcio
2026-03-17 14:50   ` Luca Weiss [this message]
2026-03-17 14:41 ` [PATCH 3/6] arm64: dts: qcom: sm8450: " Konrad Dybcio
2026-03-17 15:07   ` Neil Armstrong
2026-03-17 14:41 ` [PATCH 4/6] arm64: dts: qcom: sm8550: " Konrad Dybcio
2026-03-17 15:07   ` Neil Armstrong
2026-03-17 14:41 ` [PATCH 5/6] arm64: dts: qcom: sm8650: " Konrad Dybcio
2026-03-17 15:07   ` Neil Armstrong
2026-03-17 14:41 ` [PATCH 6/6] arm64: dts: qcom: sm8750: " Konrad Dybcio
2026-03-17 14:47 ` [PATCH 0/6] Fix up GIC_ITS ranges in QCOM DTs Abel Vesa
2026-03-19  3:31 ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DH553B1YAFG5.1UT90QXHUSGM1@fairphone.com \
    --to=luca.weiss@fairphone.com \
    --cc=abelvesa@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=jingyi.wang@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lumag@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_jprakash@quicinc.com \
    --cc=quic_molvera@quicinc.com \
    --cc=quic_rlaggysh@quicinc.com \
    --cc=quic_saipraka@quicinc.com \
    --cc=quic_tdas@quicinc.com \
    --cc=robh@kernel.org \
    --cc=tengfei.fan@oss.qualcomm.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®