From: "Luca Ceresoli" <luca.ceresoli@bootlin.com>
To: "Damon Ding" <damon.ding@rock-chips.com>,
<andrzej.hajda@intel.com>, <neil.armstrong@linaro.org>,
<rfoss@kernel.org>
Cc: <Laurent.pinchart@ideasonboard.com>, <jonas@kwiboo.se>,
<jernej.skrabec@gmail.com>, <maarten.lankhorst@linux.intel.com>,
<mripard@kernel.org>, <tzimmermann@suse.de>, <airlied@gmail.com>,
<simona@ffwll.ch>, <dmitry.baryshkov@oss.qualcomm.com>,
<dianders@chromium.org>, <m.szyprowski@samsung.com>,
<andy.yan@rock-chips.com>, <dri-devel@lists.freedesktop.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/4] drm/bridge: analogix_dp: Apply DP helper API drm_dp_clock_recovery_ok()
Date: Wed, 25 Mar 2026 13:20:15 +0100 [thread overview]
Message-ID: <DHBUWX3J06TQ.1FRN7L0920OTH@bootlin.com> (raw)
In-Reply-To: <20251110085823.1197472-3-damon.ding@rock-chips.com>
On Mon Nov 10, 2025 at 9:58 AM CET, Damon Ding wrote:
> Use existing DP helper API instead of analogix_dp_clock_recovery_ok()
> with the same function.
>
> Signed-off-by: Damon Ding <damon.ding@rock-chips.com>
> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> @@ -398,7 +385,7 @@ static int analogix_dp_process_clock_recovery(struct analogix_dp_device *dp)
> if (retval < 0)
> return retval;
>
> - if (analogix_dp_clock_recovery_ok(link_status, lane_count) == 0) {
> + if (drm_dp_clock_recovery_ok(link_status, lane_count)) {
It took a while to realize that drm_dp_clock_recovery_ok() really does the
same thing as analogix_dp_clock_recovery_ok(), but it looks fine.
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2026-03-25 12:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 8:58 [PATCH v3 0/4] Apply DP helper APIs to do link train Damon Ding
2025-11-10 8:58 ` [PATCH v3 1/4] drm/bridge: analogix_dp: Apply DP helper API drm_dp_dpcd_read_link_status() Damon Ding
2026-03-25 6:39 ` Luca Ceresoli
2025-11-10 8:58 ` [PATCH v3 2/4] drm/bridge: analogix_dp: Apply DP helper API drm_dp_clock_recovery_ok() Damon Ding
2026-03-25 12:20 ` Luca Ceresoli [this message]
2025-11-10 8:58 ` [PATCH v3 3/4] drm/bridge: analogix_dp: Apply DP helper API drm_dp_channel_eq_ok() Damon Ding
2026-03-25 12:54 ` Luca Ceresoli
2025-11-10 8:58 ` [PATCH v3 4/4] drm/bridge: analogix_dp: Apply DP helper APIs to get adjusted voltages and pre-emphasises Damon Ding
2026-03-25 12:54 ` Luca Ceresoli
2025-12-28 8:53 ` [PATCH v3 0/4] Apply DP helper APIs to do link train Damon Ding
2026-03-25 13:21 ` Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DHBUWX3J06TQ.1FRN7L0920OTH@bootlin.com \
--to=luca.ceresoli@bootlin.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=andy.yan@rock-chips.com \
--cc=damon.ding@rock-chips.com \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome